Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nesting of hashes in TermOfServiceHelper::ASSIGN_TOS #2219

Merged
merged 1 commit into from
Sep 22, 2017

Conversation

gtanzillo
Copy link
Member

The structure of the hash seems to have been inadvertently changes if commit 3c3b18f in PR #2082

The issue was discover while attempting to assign an alert profile. It failed with the error -

[----] F, [2017-09-22T14:37:47.305082 #68404:3fc8f2ef62f8] FATAL -- : Error caught: [ActionView::Template::Error] undefined method `map' for nil:NilClass
Did you mean?  tap
/Users/gtanzill/work/rh/manageiq-ui-classic/app/views/miq_policy/_alert_profile_assign.html.haml:16:in `___sers_gtanzill_work_rh_manageiq_ui_classic_app_views_miq_policy__alert_profile_assign_html_haml__3366413194070634160_70132305363060'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/actionview-5.0.6/lib/action_view/template.rb:159:in `block in render'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/activesupport-5.0.6/lib/active_support/notifications.rb:166:in `instrument'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/actionview-5.0.6/lib/action_view/template.rb:354:in `instrument'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/actionview-5.0.6/lib/action_view/template.rb:157:in `render'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/actionview-5.0.6/lib/action_view/renderer/partial_renderer.rb:343:in `render_partial'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/actionview-5.0.6/lib/action_view/renderer/partial_renderer.rb:311:in `block in render'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/actionview-5.0.6/lib/action_view/renderer/abstract_renderer.rb:42:in `block in instrument'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/activesupport-5.0.6/lib/active_support/notifications.rb:164:in `block in instrument'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/activesupport-5.0.6/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/activesupport-5.0.6/lib/active_support/notifications.rb:164:in `instrument'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/actionview-5.0.6/lib/action_view/renderer/abstract_renderer.rb:41:in `instrument'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/actionview-5.0.6/lib/action_view/renderer/partial_renderer.rb:310:in `render'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/actionview-5.0.6/lib/action_view/renderer/renderer.rb:47:in `render_partial'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/actionview-5.0.6/lib/action_view/renderer/renderer.rb:21:in `render'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/actionview-5.0.6/lib/action_view/helpers/rendering_helper.rb:32:in `render'
/Users/gtanzill/.rvm/gems/ruby-2.3.1@vmdb_5_7/gems/haml-4.0.7/lib/haml/helpers/action_view_mods.rb:12:in `render_with_haml'
/Users/gtanzill/work/rh/manageiq-ui-classic/app/views/miq_policy/_alert_profile_details.html.haml:6:in `___sers_gtanzill_work_rh_manageiq_ui_classic_app_views_miq_policy__alert_profile_details_html_haml___2248326320704882584_70132260365840'

The structure of the hash seems to have been inadvertently changes if commit 3c3b18f
@gtanzillo
Copy link
Member Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Sep 22, 2017
@miq-bot
Copy link
Member

miq-bot commented Sep 22, 2017

Checked commit gtanzillo@cf12b96 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 3 offenses detected

app/helpers/term_of_service_helper.rb

  • ❗ - Line 13, Col 5 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
  • ❗ - Line 17, Col 5 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
  • ❗ - Line 9, Col 5 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

@dclarizio
Copy link

@europ this was caused by unintentionally indented code in #2082

@dclarizio dclarizio merged commit 85cc5b8 into ManageIQ:master Sep 22, 2017
@dclarizio dclarizio added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants