Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Custom Reports node text when there is "-" present in tenant name #2229

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Fixed Custom Reports node text when there is "-" present in tenant name #2229

merged 1 commit into from
Sep 25, 2017

Conversation

h-kataria
Copy link
Contributor

https://bugzilla.redhat.com/show_bug.cgi?id=1489821

before:
before

after:
with "-" in company name
screenshot from 2017-09-25 15-41-54

without "-" in company name
screenshot from 2017-09-25 15-45-25

@dclarizio please review

@h-kataria h-kataria force-pushed the custom_report_node_title_fix branch 2 times, most recently from 8dbf44e to 37e0d9b Compare September 25, 2017 21:35
@h-kataria h-kataria force-pushed the custom_report_node_title_fix branch from 37e0d9b to 6368270 Compare September 25, 2017 22:31
@miq-bot
Copy link
Member

miq-bot commented Sep 25, 2017

Checked commit h-kataria@6368270 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@dclarizio dclarizio merged commit 6c18b65 into ManageIQ:master Sep 25, 2017
@dclarizio dclarizio added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 25, 2017
@h-kataria h-kataria deleted the custom_report_node_title_fix branch October 3, 2017 18:36
simaishi pushed a commit that referenced this pull request Nov 13, 2017
@simaishi
Merge pull request #2229 from h-kataria/custom_report_node_title_fix
a0ca93f 
Fixed Custom Reports node text when there is "-" present in tenant name
(cherry picked from commit 6c18b65)

https://bugzilla.redhat.com/show_bug.cgi?id=1496924
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit a0ca93f5dae8fb9cd8bd2c5360ec5cae5ed6e9fc
Author: Dan Clarizio <[email protected]>
Date:   Mon Sep 25 15:58:51 2017 -0700

    Merge pull request #2229 from h-kataria/custom_report_node_title_fix
    
    Fixed Custom Reports node text when there is "-" present in tenant name
    (cherry picked from commit 6c18b654cda9d0318fdec428b5f71a0c06e94787)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1496924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
bug fine/backported overview/reporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@h-kataria @miq-bot @simaishi @dclarizio