Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add physical server buttons when displaying through ems_physical_infra #2409

Merged
merged 2 commits into from
Oct 17, 2017
Merged

Add physical server buttons when displaying through ems_physical_infra #2409

merged 2 commits into from
Oct 17, 2017

Conversation

MaysaMacedo
Copy link
Member

@MaysaMacedo MaysaMacedo commented Oct 16, 2017 •
edited
Loading

This PR displays:

  • Physical server buttons when displaying Physical Server page through ems_physical_infra.
  • Physical Server policy button when showing a specific Physical Server.

image
image

@MaysaMacedo
Copy link
Member Author

MaysaMacedo commented Oct 16, 2017 •
edited
Loading

@juliancheal @agrare Could you take a look on this PR?

@juliancheal
Copy link
Member

@miq-bot assign @AparnaKarve

@miq-bot
Copy link
Member

miq-bot commented Oct 16, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Oct 16, 2017

Checked commits MaysaMacedo/manageiq-ui-classic@fd4ca15~...4833daa with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks fine. 🍰

@AparnaKarve
Copy link
Contributor

@MaysaMacedo The changes look good.

Not related to the current PR, but...
I noticed that for Refresh Relationships, there is no flash message displayed that says that Refresh initiated for the selected Physical servers

@AparnaKarve
Copy link
Contributor

@dclarizio The above issue that I mentioned is not related to the current PR.
As far as the changes in the current PR go, they are GTG.

@MaysaMacedo
Copy link
Member Author

@AparnaKarve Thanks for your feedback, I will take a look on the Refresh Relationships.

@dclarizio dclarizio merged commit 311c2bc into ManageIQ:master Oct 17, 2017
@dclarizio dclarizio added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
compute/physical infrastructure enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MaysaMacedo @juliancheal @miq-bot @AparnaKarve @dclarizio