Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various issues in Foreman UI causes by GTL. #2694

Merged
merged 3 commits into from
Nov 10, 2017
Merged

Fix various issues in Foreman UI causes by GTL. #2694

merged 3 commits into from
Nov 10, 2017

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Nov 10, 2017 •
edited
Loading

Testing:

  • go to Configuration --> Management
  • In the Providers tree click around and also click "Unassigned Profiles Group"
  • see it explode

Depends on: ManageIQ/manageiq#16439

Fixes: #2687

related bz: https://bugzilla.redhat.com/show_bug.cgi?id=1507551

This was referenced Nov 10, 2017
Closed
Merged
@miq-bot
Copy link
Member

miq-bot commented Nov 10, 2017

Checked commits martinpovolny/manageiq-ui-classic@efadddf~...1c1ac97 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@lgalis
Copy link
Contributor

lgalis commented Nov 10, 2017

@martinpovolny - Tested in the UI - looks good for the provider accordion ( an exception for tagging for a configured system node, addressed separately).

@h-kataria h-kataria added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 10, 2017
@h-kataria h-kataria merged commit 4a76f01 into ManageIQ:master Nov 10, 2017
simaishi pushed a commit that referenced this pull request Nov 15, 2017
@h-kataria @simaishi
Merge pull request #2694 from martinpovolny/foreman_fixes
a0ca148 
Fix various issues in Foreman UI causes by GTL.
(cherry picked from commit 4a76f01)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit a0ca148a9c33de4f9a608512b1a05166d675df2e
Author: Harpreet Kataria <[email protected]>
Date:   Fri Nov 10 13:13:40 2017 -0500

    Merge pull request #2694 from martinpovolny/foreman_fixes
    
    Fix various issues in Foreman UI causes by GTL.
    (cherry picked from commit 4a76f01782ea4193be678ed8be84d1e0089a78e4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
bug configuration management gaprindashvili/backported gtls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@martinpovolny @miq-bot @lgalis @simaishi @h-kataria @mzazrivec