Add a spec for chart click-through to hosts. #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @karelhala |
Merged
|
This pull request is not mergeable. Please rebase and repush. |
martinpovolny
force-pushed
the
click_through_spec
branch
from
a98ecde to
40cb120
Compare
|
@karelhala, @romanblanco : please, review! |
martinpovolny
force-pushed
the
click_through_spec
branch
from
e64848c to
f90ff05
Compare
|
Some comments on commits martinpovolny/manageiq-ui-classic@40cb120~...f90ff05 spec/controllers/host_controller_spec.rb
|
|
Checked commits martinpovolny/manageiq-ui-classic@40cb120~...f90ff05 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 21, 2017
Add a spec for chart click-through to hosts. (cherry picked from commit da20aec)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec for:
#2740
requires:
#2727
pending rebase
@miq-bot add_label gaprindashvili/yes
@miq-bot add_label test