Add an exception for middleware server listicons to prefer fileicon

[skateman]

Adding exceptions is the worst way of fixing this issue, however, after consulting with @epwinchell I did not find any other option. For now a fonticon has a higher priority than a fileicon which is a problem in the middleware server listview. Eventually we want to swap these priorities, however, we have some legacy fileicons that are PNG based and they should be deleted, but for now the quadicons depend on them. So until we have fonticon support in quadicons, we can't swap the priority and adding this exception seemed the simplest possible solution.

But maybe I'm wrong and @karelhala, @himdel or @martinpovolny could come up with a better idea.

Before:

After:

https://bugzilla.redhat.com/show_bug.cgi?id=1509935

[abonas]

@miq-bot add_label middleware, bug

[martinpovolny]

Oh my this method is a 💩 But right. We need to refactor this after Gaprindashvili.

[ohadlevy]

can you add a test please? :) thanks

[martinpovolny]

@skateman : my first thought seeing @ohadlevy 's comment is "No, not here". Because mocking everything so that you can add a unit test for the simple condition here will result in an ugly test that we will have to rework right in the moment where we start cleaning up this messy method (after Gaprindashvili).

But I suggest that you add a /report_data integration test for the listing of Middeware servers. If you do that using #2727 and not only test the icon, but test that there's data in the listing -- correct number of rows, the right middleware server in the view and on top of that there's the correct icon.

There will be value in the test and it will not need to be an ugly pile of stubs.

Also @abonas and her guys can use that as an example for adding test coverage to other screens with grids under middleware.

Can you do that? Shall I help?

p.s. And such test will stay untouched when we refactor view_to_hash and will actually serve to ensure that we don't break things when we do that.

[miq-bot]

Checked commit skateman@af0d084 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

[martinpovolny]

@abonas : Gaprindashvili?

[skateman]

@martinpovolny yes, have a BZ for that too
@miq-bot add_label gaprindashvili/yes

[abonas]

@martinpovolny yes, definitely gaprindashvili, the bz reflects it correctly.
Thanks all!

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 5912d56ad1a03db9c9cc2e0ff0d28210b231d126
Author: Martin Povolny <[email protected]>
Date:   Fri Dec 1 11:00:43 2017 +0100

    Merge pull request #2888 from skateman/middleware-server-listicon
    
    Add an exception for middleware server listicons to prefer fileicon
    (cherry picked from commit 0ba0097ce2319226f756391c33720aa6f182c90c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1510248