Remove record.id from live migrate submit and cancel buttons

[mansam]

Remove erroneous reference to @record.id from the submit and cancel buttons that are displayed when viewing the live migrate form outside of an explorer view. IDs of instances to migrate are tracked by @live_migrate_items.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1518436
Obsoletes #2877

[mansam]

@miq_bot add_label bug
@miq_bot add_label compute/cloud
@miq_bot add_label gaprindashvili/yes

[miq-bot]

Checked commit mansam@5dfeb89 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

[martinpovolny]

@aufi : please, confim, this fixes the issue. Thx!

[martinpovolny]

@mansam : do you need any help with writing a simple test for this one?

[mansam]

@martinpovolny Some guidance about how to write a test for this would be helpful.

[martinpovolny]

You are fixing a crash. So you can write a test that will check that the page renders ok.

Create a VM. And run the request that is run then you press the button.

I don't know if the id of the VM is passwd in the request or is stored beforehand in the session. You can easily see what's going on in the browser development tools.

There's a grid on that page so you can check that the GTL rendering is called with the proper params. You can also check that the /report_data returns the proper VMs to be displayed in the grid. Example: https://github.com/ManageIQ/manageiq-ui-classic/pull/2842/files

Ping me when you have some WIP and you need any help.

[aufi]

Works for me 👍 (but there are some warnings, not sure if it is related to this PR)

[mansam]

@martinpovolny I am having trouble rendering the request outside of explorer mode. Calling "post :x_button, :params => :pressed => "instance_live_migrate" renders the form in an explorer with no apparent way to change that, and doing post :button, :etc,etc,etc doesn't work-- it returns a 500 saying the button is unimplemented.

    session[:live_migrate_items] = [vm_openstack.id]
    post :button, :params => {:pressed => 'instance_live_migrate'}
    expect(response.status).to eq(200)
    expect(response).to render_template(:partial => 'vm_common/_live_migrate')

[martinpovolny]

ok, @mansam, let me look if I can craft a spec tomorrow.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 10ad9d813cc83da4be0dea4600a4feb62f9f2522
Author: Martin Povolny <[email protected]>
Date:   Thu Dec 7 21:36:36 2017 +0100

    Merge pull request #2891 from mansam/fix-live-migrate-outside-explorer-views
    
    Remove record.id from live migrate submit and cancel buttons
    (cherry picked from commit 5e3c9a5c85e08ec254d59b6a16799548a83ab19c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1524676