Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display confirmation message when Adding new PXE Server #2893

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

GregP
Copy link
Contributor

@GregP GregP commented Nov 30, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1518142

Screen shot prior to code fix:
new pxe server added with no confirmation message

Screen shot post code fix:
new pxe server added message post code fix

@miq-bot
Copy link
Member

miq-bot commented Dec 1, 2017

Checked commit GregP@96ba857 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@GregP GregP closed this Dec 1, 2017
@GregP GregP reopened this Dec 1, 2017
@mzazrivec mzazrivec self-assigned this Dec 1, 2017
@mzazrivec mzazrivec added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 1, 2017
@mzazrivec mzazrivec merged commit 6f75aaa into ManageIQ:master Dec 1, 2017
simaishi pushed a commit that referenced this pull request Dec 1, 2017
Display confirmation message when Adding new PXE Server
(cherry picked from commit 6f75aaa)

https://bugzilla.redhat.com/show_bug.cgi?id=1519943
@simaishi
Copy link
Contributor

simaishi commented Dec 1, 2017

Gaprindashvili backport details:

$ git log -1
commit 4d1b5a93b3f77eff595447d2b59e8aee0d217d03
Author: Milan Zázrivec <[email protected]>
Date:   Fri Dec 1 11:56:21 2017 +0100

    Merge pull request #2893 from GregP/display_msg_new_pxe_server
    
    Display confirmation message when Adding new PXE Server
    (cherry picked from commit 6f75aaae4520a9c6ae6314b8437fd3f0bc44b2a4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1519943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants