Display only the inline methods in the embedded methods tree

[skateman]

The TreeBuilder calls are playing too much with the session, I even failed with a simpler solution. I decided to utilize the same TreeSelector component that we're using in the dialog editor for entry point selection. I created a new method into the TreeController that retrieves a special automate tree with inline methods only. The most complicated part was the link between the session-based edit form and the angular controller, but I sorted it out by salvaging @pkomanek's code into a new embedded_methods_add route.

I also tried to remove some dead code, but maybe missed a lot ... so this needs future refactoring.

https://bugzilla.redhat.com/show_bug.cgi?id=1512683

ping @martinpovolny @himdel @mkanoor

[miq-bot]

Checked commits skateman/manageiq-ui-classic@69a8393~...22d72d9 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
8 files checked, 0 offenses detected
Everything looks fine. 🍪

[himdel]

LGTM, should not touch session anymore :) (also, matches what we do when chosing the method in catalog explorer)

Tested in UI - Automation > Automate > Explorer - ... - add a new method, type = inline

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 55741b02ec5691b385934c2c41aae2f94cd7d835
Author: Martin Hradil <[email protected]>
Date:   Fri Dec 15 14:25:35 2017 +0100

    Merge pull request #3050 from skateman/inline-methods-tree
    
    Display only the inline methods in the embedded methods tree
    (cherry picked from commit 2c1ff87075758ae39f3509c96db32249f07cca36)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1526585

[mkanoor]

@skateman
👍 Looks good. The only comment would be if the nodes are empty should we display those nodes. If there are no inline methods should we display those namespace/class

[skateman]

@mkanoor as we use lazy loading, we don't know how many grandchildren a node has without doing something time consuming.