Switched fields around on the form/summary screen. #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After user entered data in Default value field and then switched Data Type drop down value, form resets Default Value field to be empty which was causing confusion. By switching fields around user will first pick data type and then enter data in Default Value field. To be consistent switched fields on both Ansible/Non-Ansible forms. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1525584
|
Checked commit h-kataria@b8fa8f6 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 app/views/miq_ae_class/_inputs.html.haml
|
|
@billfitzgerald0120 could you please review? |
|
@h-kataria @dclarizio Looks good. |
simaishi
pushed a commit
that referenced
this pull request
Dec 19, 2017
Switched fields around on the form/summary screen. (cherry picked from commit b2fff54) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527572
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After user entered data in Default value field and then switched Data Type drop down value, form resets Default Value field to be empty which was causing confusion. By switching fields around user will first pick data type and then enter data in Default Value field.
To be consistent switched fields on both Ansible/Non-Ansible forms.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1525584
before:
after:
@mkanoor please review.