Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove middleware default view settings configuration #3118

Merged
merged 1 commit into from
Dec 22, 2017
Merged

Remove middleware default view settings configuration #3118

merged 1 commit into from
Dec 22, 2017

Conversation

abonas
Copy link
Member

@abonas abonas commented Dec 20, 2017 •
edited
Loading

Removing middleware settings from the default views page:
defaultviews

@abonas
Copy link
Member Author

abonas commented Dec 20, 2017

@miq-bot add_label middleware

@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2017

Checked commit abonas@36ddf18 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@abonas
Copy link
Member Author

abonas commented Dec 20, 2017

@karelhala

@mzazrivec mzazrivec added the wip label Dec 21, 2017
@mzazrivec mzazrivec changed the title WIP Remove middleware default view settings configuration [WIP] Remove middleware default view settings configuration Dec 21, 2017
@abonas
Copy link
Member Author

abonas commented Dec 21, 2017

@miq-bot add_label gaprindashvili/yes

@abonas
Copy link
Member Author

abonas commented Dec 21, 2017

@ManageIQ/core-hawkular please review. imo there is something missing/something is persisted elsewhere because the screen is still presenting the middleware section on my env even after this code removal and miq restart.

@karelhala
Copy link
Contributor

Can verify, that after aplying this PR middleware section is no longer visible

screenshot from 2017-12-21 14-17-53

@abonas abonas changed the title [WIP] Remove middleware default view settings configuration Remove middleware default view settings configuration Dec 21, 2017
@abonas
Copy link
Member Author

abonas commented Dec 21, 2017

@miq-bot rm_label wip

@miq-bot miq-bot removed the wip label Dec 21, 2017
@abonas
Copy link
Member Author

abonas commented Dec 21, 2017

scrutinizer seem to show errs unrelated to this PR

israel-hdez
israel-hdez approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't see the settings 👍

@chessbyte chessbyte self-assigned this Dec 22, 2017
@chessbyte chessbyte merged commit 2dcb6d9 into ManageIQ:master Dec 22, 2017
@chessbyte chessbyte added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 22, 2017
@cfcosta cfcosta mentioned this pull request Jan 2, 2018
Merged
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit 01c60fa3fd90c2ae841aec31a8fd0f39e09ecae8
Author: Oleg Barenboim <[email protected]>
Date:   Thu Dec 21 22:07:10 2017 -0500

    Merge pull request #3118 from abonas/removeMiddlewareDefaultSettings
    
    Remove middleware default view settings configuration
    (cherry picked from commit 2dcb6d91db48aa51a8dd9f4ceb4b061a3fbf5a14)

simaishi pushed a commit that referenced this pull request Jan 3, 2018
@chessbyte @simaishi
Merge pull request #3118 from abonas/removeMiddlewareDefaultSettings
01c60fa 
Remove middleware default view settings configuration
(cherry picked from commit 2dcb6d9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelhala karelhala karelhala approved these changes

@israel-hdez israel-hdez israel-hdez approved these changes

Assignees

@chessbyte chessbyte

Labels
gaprindashvili/backported middleware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@abonas @miq-bot @karelhala @simaishi @israel-hdez @chessbyte @mzazrivec