Remove nil elements from top_nodes array. #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even when section was skipped in x_get_tree_roots method a nil was being added to top_nodes array that was causing undefined method `new' for nil:NilClass in /app/presenters/tree_node.rb:9. This fix removes any nil elements from array before trying to build RBAC features tree. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533391
|
Checked commit h-kataria@1c21e1b with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 spec/presenters/tree_builder_ops_rbac_features_spec.rb
|
|
@lgalis to recreate this, you can copy config/permissions.tml.yml file in core to permissions.yml and for example remove :sto key from there and restart the server, then try to go to Any roles details screen or Add/Edit a role screen, that should blow up |
simaishi
pushed a commit
that referenced
this pull request
Jan 12, 2018
Remove nil elements from top_nodes array. (cherry picked from commit d51bc75) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533391
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when section was skipped in x_get_tree_roots method a nil was being added to top_nodes array that was causing undefined method `new' for nil:NilClass
in /app/presenters/tree_node.rb:9. This fix removes any nil elements from array before trying to build RBAC features tree.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533391
@lgalis please test.