Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grouping in CU charts #335

Merged
merged 1 commit into from
Feb 21, 2017
Merged

Fix grouping in CU charts #335

merged 1 commit into from
Feb 21, 2017

Conversation

PanSpagetka
Copy link
Contributor

@PanSpagetka PanSpagetka commented Feb 9, 2017 •
edited
Loading

Fix broken grouping for C&U charts. Reintroduced bug with missing bad formatting for these charts. Will fix in following PR.

https://bugzilla.redhat.com/show_bug.cgi?id=1417794

Screenshots

Before:
screencapture-localhost-3000-host-show-10000000000017-1487063395008

After:
screencapture-localhost-3000-host-show-10000000000017-1487063016635

How to test

  1. Have some provider with C&U
  2. Refresh Provider
  3. Find VM cu-24x7 and tag it.
  4. Find its cluster.
  5. Go to Configuration -> Server, turn on C&U
  6. Go to Configuration -> Region -> C&U Collection turn on for cluster.
  7. Go to Configuration -> Region -> Red Hat Categories turn on Capture C&U for category you use to tag VM.
  8. Find host Monitoring -> Utilization -> Select Group by category which you set

You may need to wait some time to collect some C&U data

@miq-bot miq-bot added the wip label Feb 9, 2017
@PanSpagetka PanSpagetka force-pushed the fix-cu-chart-grouping branch from 0c12e59 to adedf72 Compare February 13, 2017 09:31
@PanSpagetka PanSpagetka force-pushed the fix-cu-chart-grouping branch from adedf72 to 7b2d687 Compare February 13, 2017 09:33
@miq-bot
Copy link
Member

miq-bot commented Feb 13, 2017

Checked commit PanSpagetka@7b2d687 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@PanSpagetka PanSpagetka changed the title [WIP] Fix grouping in CU charts Fix grouping in CU charts Feb 14, 2017
@PanSpagetka
Copy link
Contributor Author

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Feb 14, 2017
@PanSpagetka PanSpagetka mentioned this pull request Feb 14, 2017
Merged
@martinpovolny
Copy link
Member

Can you add a simple test?

@PanSpagetka
Copy link
Contributor Author

Add specs to following PR #382

@martinpovolny martinpovolny merged commit 7504907 into ManageIQ:master Feb 21, 2017
@martinpovolny martinpovolny added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 21, 2017
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2017

Euwe backport (to manageiq repo) details:

$ git log -1
commit 300286a8759246a1e4709e5823dd738f6a32f27f
Author: Martin Povolny <[email protected]>
Date:   Tue Feb 21 19:28:37 2017 +0100

    Merge pull request #335 from PanSpagetka/fix-cu-chart-grouping
    
    Fix grouping in CU charts
    (cherry picked from commit 7504907d4439bb66fede7da0b2a639fe856ed000)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1426628

@romanblanco romanblanco mentioned this pull request Jan 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
bug charts euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PanSpagetka @miq-bot @martinpovolny @simaishi @chessbyte