Make view selector of All Generic Objects page work #3423
Conversation
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1545296 Make view selector of All Generic Objects page work, when attaching GO to a service and navigating to Services > My Services > service with GO and clicking on Instances from Generic Objects table (where we can change the view from tile also to grid/list).
|
@miq-bot add_label bug, gaprindashvili/yes |
|
Checked commit hstastna@3b5b419 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
| @@ -69,6 +69,7 @@ def show | |||
| def set_display | |||
| @display = params[:display] | |||
| @display ||= default_display unless pagination_or_gtl_request? | |||
| @display ||= 'generic_objects' if role_allows?(:feature => "generic_object_view") && @record.number_of(:generic_objects).positive? | |||
There was a problem hiding this comment.
This looks strange. We want to set display to 'generic_objects' if the request is a pagination_or_gtl_request?
There was a problem hiding this comment.
@display was not set for All Generic Objects page and we needed it - this is why it did not work.
"We want to set display to 'generic_objects' if the request is a pagination_or_gtl_request?"
... Hmm, I see there something slightly different: if the request is a pagination_or_gtl_request, @display still does not have to be set to 'generic_objects', because there is condition: if role_allows?(:feature => "generic_object_view") && @record.number_of(:generic_objects).positive? which has to be true for @display to be set to generic_objects ... Or did you mean to change this condition to something else? This worked for me the best. I also think that @display does not have to be always set.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1545296
Make view selector of All Generic Objects page work, when attaching GO to a service
and navigating to Services > My Services > service with GO and clicking on Instances
from Generic Objects table (where we can change the view from tile also to grid/list).
Right before changing the view in All Generic Objects page (now default Tile view):
Before: (after clicking on Grid/List view from All Generic Objects page)
After:
