Fix name of 'Physical Infrastructure Providers' on the Physical Infrastructure Providers page #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug, gaprindashvili/yes |
himdel
reviewed
Mar 12, 2018
| N_('Remove selected Infrastructure Providers from Inventory'), | ||
| N_('Remove Infrastructure Providers from Inventory'), | ||
| N_('Remove selected Physical Infrastructure Providers from Inventory'), | ||
| N_('Remove Physical Infrastructure Providers from Inventory'), | ||
| :url_parms => "main_div", | ||
| :send_checked => true, | ||
| :confirm => N_("Warning: The selected Infrastructure Providers and ALL of their components will be permanently removed!"), |
There was a problem hiding this comment.
Also here? ;) And lines 12 and 16...
There was a problem hiding this comment.
Thank you @himdel , I also add in these lines
…vider' on Physical Infrastructure page
douglasgabriel
force-pushed
the
fix_physical_infra_name
branch
from
0c8668d to
16d4ddf
Compare
|
Checked commit douglasgabriel@16d4ddf with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM, waiting for green travis, thanks :) |
simaishi
pushed a commit
that referenced
this pull request
Mar 12, 2018
Fix name of 'Physical Infrastructure Providers' on the Physical Infrastructure Providers page (cherry picked from commit dc91c0e) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1554454
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
This PR fixes the error described here https://bugzilla.redhat.com/show_bug.cgi?id=1525116