Hide "Hide Deprecated" checkbox and remove "Deprecated" column when provisioning infra VM #3615

hstastna · 2018-03-13T17:40:09Z

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1399378

On pre provisioning screen, hide "Hide Deprecated" checkbox and remove "Deprecated" column from the table when user is submitting a provisioning request for Infrastructure VM, as those (the checkbox and the column) apply only to cloud provisioning. Cloud provisioning remains unchanged.

Before:

After:

hstastna · 2018-03-13T17:40:26Z

@miq-bot add_label bug

hstastna · 2018-03-13T18:12:05Z

@miq-bot remove_label wip

skateman · 2018-04-17T07:52:13Z

app/views/miq_request/_pre_prov.html.haml

-           :onclick => "miqAjax('" + url_for_only_path({:action => "vm_pre_prov", :id => id.to_s, :hide_deprecated_templates => !@edit[:hide_deprecated_templates]}) + "')",
-           :checked => @edit[:hide_deprecated_templates]}
-      = _('Hide deprecated')
+    - if request.parameters[:controller] == "vm_cloud"


Here you can test against @edit[:hide_deprecated_templates] instead.

skateman · 2018-04-17T07:52:44Z

app/views/miq_request/_pre_prov_images.html.haml

@@ -17,8 +17,9 @@
    = h(number_to_human_size(row.mem_cpu.to_i * 1024 * 1024))
  %td
    = h(number_to_human_size(row.allocated_disk_storage))
-  %td
-    = h(row.deprecated ? _("true") : _("false"))
+  - if @edit[:vm_headers].key? 'deprecated'


Please use parentheses around the argument.

skateman · 2018-04-17T07:53:05Z

app/views/miq_request/_prov_vm_grid.html.haml

@@ -52,8 +52,9 @@
              = h(number_to_human_size(row.mem_cpu.to_i * 1024 * 1024))
            %td
              = h(number_to_human_size(row.allocated_disk_storage))
-            %td
-              = h(row.deprecated ? _("true") : _("false"))
+            - if @edit[:vm_headers].key? 'deprecated'


same here...

skateman · 2018-04-17T07:54:08Z

app/views/miq_request/_prov_vm_grid.html.haml

@@ -85,8 +86,9 @@
            = h(number_to_human_size(@vm.mem_cpu.to_i * 1024 * 1024))
          %td
            = h(number_to_human_size(@vm.allocated_disk_storage))
-          %td
-            = h(@vm.deprecated ? _("true") : _("false"))
+          - if @edit[:vm_headers].key? 'deprecated'


You should omit parentheses only when you're using a DSL and here you're clearly not.

On pre provisioning screen, hide "Hide Deprecated" checkbox when user is submitting a provisioning request for Infrastructure VM.

@edit

Also set @edit[:hide_deprecated_templates] to true only if cloud provisioning.

Remove 'Deprecated' column from the grid after a template is selected, when Infrastructure provisioning.

hstastna · 2018-04-17T11:51:14Z

@skateman I think the changes should be done ;)
Note: I used unless.. .nil? in the haml because nothing or present? returned false also for false value, not just for nil, and this would lead to another bug (the checkbox would disappear in cloud instances, after unchecking it, when provisioning instances)

miq-bot · 2018-04-17T11:58:34Z

Checked commits hstastna/manageiq-ui-classic@8050114~...13620b3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 1 offense detected

**

💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

skateman

hstastna · 2018-04-18T13:43:56Z

@miq-bot add_label gaprindashvili/yes

hstastna · 2018-05-23T12:00:46Z

@martinpovolny @mzazrivec Could you please look at this PR? Any comment appreciated. Thanks!

miq-bot added bug wip labels Mar 13, 2018

hstastna changed the title ~~[WIP] Hide "Hide Deprecated" checkbox and remove "Deprecated" column when provisioning infra VM~~ Hide "Hide Deprecated" checkbox and remove "Deprecated" column when provisioning infra VM Mar 13, 2018

miq-bot removed wip labels Mar 13, 2018

skateman suggested changes Apr 17, 2018

View reviewed changes

hstastna force-pushed the Infra_provisio_template_deprecated_checkbox branch from cd1ed41 to 936da9f Compare April 17, 2018 10:56

Hilda Stastna added 3 commits April 17, 2018 13:49

Hide 'Hide Deprecated' checkbox when provisioning infra VM

8050114

On pre provisioning screen, hide "Hide Deprecated" checkbox when user is submitting a provisioning request for Infrastructure VM.

Remove 'Deprecated' from the headers when Infrastructure provisioning

9ed556e

Also set @edit[:hide_deprecated_templates] to true only if cloud provisioning.

Remove 'Deprecated' column from the grid after template selection

13620b3

Remove 'Deprecated' column from the grid after a template is selected, when Infrastructure provisioning.

hstastna force-pushed the Infra_provisio_template_deprecated_checkbox branch from 936da9f to 13620b3 Compare April 17, 2018 11:49

skateman approved these changes Apr 17, 2018

View reviewed changes

miq-bot added the gaprindashvili/yes label Apr 18, 2018

mzazrivec added the compute/infrastructure label May 23, 2018

mzazrivec self-assigned this May 23, 2018

mzazrivec added this to the Sprint 87 Ending Jun 4, 2018 milestone May 23, 2018

mzazrivec merged commit 98ac39a into ManageIQ:master May 23, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide "Hide Deprecated" checkbox and remove "Deprecated" column when provisioning infra VM #3615

Hide "Hide Deprecated" checkbox and remove "Deprecated" column when provisioning infra VM #3615

hstastna commented Mar 13, 2018 •

edited

Loading

hstastna commented Mar 13, 2018

hstastna commented Mar 13, 2018

skateman Apr 17, 2018

skateman Apr 17, 2018

skateman Apr 17, 2018

skateman Apr 17, 2018

hstastna commented Apr 17, 2018 •

edited

Loading

miq-bot commented Apr 17, 2018

skateman left a comment

hstastna commented Apr 18, 2018

hstastna commented May 23, 2018

Hide "Hide Deprecated" checkbox and remove "Deprecated" column when provisioning infra VM #3615

Hide "Hide Deprecated" checkbox and remove "Deprecated" column when provisioning infra VM #3615

Conversation

hstastna commented Mar 13, 2018 • edited Loading

hstastna commented Mar 13, 2018

hstastna commented Mar 13, 2018

skateman Apr 17, 2018

Choose a reason for hiding this comment

skateman Apr 17, 2018

Choose a reason for hiding this comment

skateman Apr 17, 2018

Choose a reason for hiding this comment

skateman Apr 17, 2018

Choose a reason for hiding this comment

hstastna commented Apr 17, 2018 • edited Loading

miq-bot commented Apr 17, 2018

skateman left a comment

Choose a reason for hiding this comment

hstastna commented Apr 18, 2018

hstastna commented May 23, 2018

hstastna commented Mar 13, 2018 •

edited

Loading

hstastna commented Apr 17, 2018 •

edited

Loading