AeResolveOptions - use ng-if instead of ng-show #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The partial is used only under specific circumstances, but using ng-show means all the required fields are always required, even when not visible. This makes it impossible to create a new schedule when using one of the types which don't show `object_request`. (Because the form is not valid, but the required field is not visible.) Changing to ng-if, which will not try to validate invisible fields.
|
|
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/62b27048267122efe1422be659764e150893ffdc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@himdel LGTM !! |
nimrodshn
approved these changes
Mar 28, 2018
simaishi
pushed a commit
that referenced
this pull request
Apr 2, 2018
AeResolveOptions - use ng-if instead of ng-show (cherry picked from commit f5101f5) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1562800
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The partial is used only under specific circumstances,
but using ng-show means all the required fields are always required, even when not visible.
This makes it impossible to create a new schedule when using one of the types which don't show
object_request.(Because the form is not valid, but the required field is not visible.)
Changing to ng-if, which will not try to validate invisible fields.
(Introduced in #3613, cc @ZitaNemeckova)
(Fixes ☝️ March 27, 2018 8:51 AM, cc @nimrodshn)
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1560949