Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VM quadicon links in Services #372

Merged
merged 1 commit into from
Feb 14, 2017
Merged

Fix VM quadicon links in Services #372

merged 1 commit into from
Feb 14, 2017

Conversation

hayesr
Copy link
Contributor

@hayesr hayesr commented Feb 13, 2017

A cached hash led to different Quadicons rendering with the same url info. It was discovered at the bottom of the Services > My Services screen, but could possibly happen elsewhere.

Steps to reproduce

  • Go to Services > My Services
  • Find a service with multiple vms
  • Observe urls for quadicons at the bottom

Addresses
https://bugzilla.redhat.com/show_bug.cgi?id=1406833

@hayesr
Do not cache vm_quad_link_attributes
0da3d06 
it leads to incorrect links on screens with multiple VM Quadicons.

https://bugzilla.redhat.com/show_bug.cgi?id=1406833
@hayesr
Copy link
Contributor Author

hayesr commented Feb 13, 2017

@miq-bot add_label ui, bug

@miq-bot
Copy link
Member

miq-bot commented Feb 13, 2017

Checked commit hayesr@0da3d06 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

@mzazrivec mzazrivec self-assigned this Feb 14, 2017
@mzazrivec mzazrivec added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 14, 2017
@mzazrivec mzazrivec merged commit 92d2a99 into ManageIQ:master Feb 14, 2017
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2017

Euwe backport (to manageiq repo) details:

$ git log -1
commit efcd7060d2e932d3aa2cbf10e3b46fcd6fbf0180
Author: Milan Zázrivec <[email protected]>
Date:   Tue Feb 14 09:59:53 2017 +0100

    Merge pull request #372 from hayesr/fix_dup_vm_quad_services
    
    Fix VM quadicon links in Services
    (cherry picked from commit 92d2a99ab654c50591d3deec1ac0c290028ffdd2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1430089

@hayesr hayesr deleted the fix_dup_vm_quad_services branch March 8, 2017 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hayesr @miq-bot @simaishi @mzazrivec