[FINE] Fix Reset button for tag page in Services #3804

hstastna · 2018-04-19T16:44:46Z

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1569523
https://bugzilla.redhat.com/show_bug.cgi?id=1569524

Related PRs:
#2680
#3217

Fix Reset button for tag page opened from Service item detail page in Services
-> My Services so that service_tag as an action was added to service controller.

Tagging edit page before clicking on Reset button:

Before: (no change in the page)

[----] I, [2018-04-19T18:42:03.418572 #5304:2af5979d81c4]  INFO -- : Started POST "/service/service_tag/10000000000387?button=reset" for ::1 at 2018-04-19 18:42:03 +0200
[----] I, [2018-04-19T18:42:03.451730 #5304:2af5979d81c4]  INFO -- : Processing by ServiceController#service_tag as JS
[----] I, [2018-04-19T18:42:03.451878 #5304:2af5979d81c4]  INFO -- :   Parameters: {"button"=>"reset", "id"=>"10000000000387"}
[----] W, [2018-04-19T18:42:03.509574 #5304:2af5979d81c4]  WARN -- : DEPRECATION WARNING: Method each_with_object is deprecated and will be removed in Rails 5.1, as `ActionController::Parameters` no longer inherits from hash. Using this deprecated behavior exposes potential security problems. If you continue to use this method you may be creating a security vulnerability in your app that can be exploited. Instead, consider using one of these documented methods which are not deprecated: http://api.rubyonrails.org/v5.0.7/classes/ActionController/Parameters.html (called from find_checked_items at /home/hstastna/manageiq/fine_branch/manageiq-ui-classic/app/controllers/mixins/checked_id_mixin.rb:17)
[----] I, [2018-04-19T18:42:03.708373 #5304:2af5979d81c4]  INFO -- :   Rendered /home/hstastna/manageiq/fine_branch/manageiq-ui-classic/app/views/service/_svcs_show.html.haml (7.1ms)
[----] F, [2018-04-19T18:42:03.708656 #5304:2af5979d81c4] FATAL -- : Error caught: [ActionView::Template::Error] undefined method `type' for nil:NilClass
/home/hstastna/manageiq/fine_branch/manageiq-ui-classic/app/views/service/_svcs_show.html.haml:6:in `__home_hstastna_manageiq_fine_branch_manageiq_ui_classic_app_views_service__svcs_show_html_haml__3537479409044458971_70232977656260'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/template.rb:159:in `block in render'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.0.7/lib/active_support/notifications.rb:166:in `instrument'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/template.rb:354:in `instrument'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/template.rb:157:in `render'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/renderer/partial_renderer.rb:343:in `render_partial'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/renderer/partial_renderer.rb:311:in `block in render'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/renderer/abstract_renderer.rb:42:in `block in instrument'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.0.7/lib/active_support/notifications.rb:164:in `block in instrument'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.0.7/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.0.7/lib/active_support/notifications.rb:164:in `instrument'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/renderer/abstract_renderer.rb:41:in `instrument'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/renderer/partial_renderer.rb:310:in `render'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/renderer/renderer.rb:47:in `render_partial'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/renderer/renderer.rb:21:in `render'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/rendering.rb:104:in `_render_template'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionpack-5.0.7/lib/action_controller/metal/streaming.rb:217:in `_render_template'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/rendering.rb:83:in `render_to_body'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionpack-5.0.7/lib/action_controller/metal/rendering.rb:52:in `render_to_body'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionpack-5.0.7/lib/action_controller/metal/renderers.rb:142:in `render_to_body'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionpack-5.0.7/lib/abstract_controller/rendering.rb:48:in `render_to_string'
/home/hstastna/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionpack-5.0.7/lib/action_controller/metal/rendering.rb:41:in `render_to_string'
/home/hstastna/manageiq/fine_branch/manageiq-ui-classic/app/controllers/service_controller.rb:320:in `block in replace_right_cell'
/home/hstastna/manageiq/fine_branch/manageiq-ui-classic/app/controllers/service_controller.rb:333:in `replace_right_cell'
/home/hstastna/manageiq/fine_branch/manageiq-ui-classic/app/controllers/application_controller/tags.rb:155:in `tagging_edit_tags_reset'
/home/hstastna/manageiq/fine_branch/manageiq-ui-classic/app/controllers/application_controller/tags.rb:18:in `tagging_edit'
/home/hstastna/manageiq/fine_branch/manageiq-ui-classic/app/controllers/application_controller/tags.rb:23:in `service_tag'

After:

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1569523 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1569524 Fix Reset button for tag page opened from Service item detail page in Services -> My Services so that service_tag as an action was added to service controller.

hstastna · 2018-04-19T16:45:06Z

@miq-bot add_label bug

miq-bot · 2018-04-19T17:03:35Z

Checked commit hstastna@6058681 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

hstastna · 2018-07-11T09:38:22Z

@mzazrivec Milan, could you, please, review the changes? Thank you! :)

hstastna · 2018-09-21T09:24:26Z

@simaishi ping

simaishi · 2018-09-21T15:23:29Z

@hstastna I'm not able to merge/backport any PR that's not a blocker for the next release...

simaishi · 2018-12-11T19:27:27Z

No longer making updates to fine branch, closing.

miq-bot added the bug label Apr 19, 2018

hstastna mentioned this pull request Apr 19, 2018

Fix Reset button for tag page in Services #2680

Merged

hstastna changed the title ~~Fix Reset button for tag page in Services~~ [FINE] Fix Reset button for tag page in Services Apr 19, 2018

simaishi requested a review from mzazrivec April 19, 2018 16:49

simaishi self-assigned this Apr 19, 2018

simaishi closed this Apr 24, 2018

simaishi reopened this Apr 24, 2018

mzazrivec approved these changes Jul 11, 2018

View reviewed changes

simaishi closed this Dec 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FINE] Fix Reset button for tag page in Services #3804

[FINE] Fix Reset button for tag page in Services #3804

hstastna commented Apr 19, 2018 •

edited

Loading

hstastna commented Apr 19, 2018

miq-bot commented Apr 19, 2018

hstastna commented Jul 11, 2018

hstastna commented Sep 21, 2018

simaishi commented Sep 21, 2018

simaishi commented Dec 11, 2018

[FINE] Fix Reset button for tag page in Services #3804

[FINE] Fix Reset button for tag page in Services #3804

Conversation

hstastna commented Apr 19, 2018 • edited Loading

hstastna commented Apr 19, 2018

miq-bot commented Apr 19, 2018

hstastna commented Jul 11, 2018

hstastna commented Sep 21, 2018

simaishi commented Sep 21, 2018

simaishi commented Dec 11, 2018

hstastna commented Apr 19, 2018 •

edited

Loading