Pull out health_state from physical infra decorators to the helper #4054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skateman 'saulotoledo' is an invalid reviewer, ignoring... |
skateman
changed the title
skateman
force-pushed
the
health-state-helper
branch
from
25d1cff to
952076b
Compare
epwinchell
approved these changes
Jun 5, 2018
skateman
changed the title
skateman
force-pushed
the
health-state-helper
branch
from
952076b to
cd3531e
Compare
skateman
force-pushed
the
health-state-helper
branch
from
cd3531e to
146d482
Compare
|
Checked commit skateman@146d482 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared code needs to go to the
QuadiconHelperso we don't need to maintain it at two places. I am still looking into joining this together with themachine_stateorstatus_icon. This change will allow us to replace fileicons with fonticons.@miq-bot add_reviewer @epwinchell
@miq-bot add_label gaprindashvili/no, compute/physical infrastructure, refactoring