-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix units in C&U grouped charts #41
Conversation
https://bugzilla.redhat.com/show_bug.cgi?id=1401441 (cherry picked from commit b18bc4ed950bd1161d0d874a1b34655d012b84b3)
https://bugzilla.redhat.com/show_bug.cgi?id=1367560 (cherry picked from commit b2ec6ce89bdc40e9ba26fcf8f1b6f8d3eff580e0)
Checked commits PanSpagetka/manageiq-ui-classic@5b6a3ba~...a60e3c0 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
@PanSpagetka What about the multiple lines in the chart showing the same value? |
@mzazrivec see @PanSpagetka's line in the first comment:
|
@dclarizio Yep, thanks. That line wasn't there before though. |
@romanblanco does this need darga/yes flag as well? |
@dclarizio I didnt test it in darga, this bug is probably present there. But the BZ is for cfme-future so I am not sure... |
thanks, @PanSpagetka 😄 |
@PanSpagetka The bug was found in 5.6/Darga, so might need a fix there . . . I will flag the BZ for Euwe and we'll see if someone else wants it for Darga or not. |
Euwe backport (to manageiq repo) details:
|
"Fix" units in C&U grouped charts. More like hack grouped chart to look like it's working...
I am dealing with duplicate values in #40
Screenshots
Before:
After:
![screencapture-localhost-3000-host-show-10000000000017-1482244721276](https://cloud.githubusercontent.com/assets/9535558/21354447/6d56c390-c6ca-11e6-828a-6d565172bdc5.png)
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1367560
(converted from ManageIQ/manageiq#13273)