Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix units in C&U grouped charts #41

Merged
merged 2 commits into from
Jan 6, 2017

Conversation

PanSpagetka
Copy link
Contributor

@PanSpagetka PanSpagetka commented Jan 2, 2017

"Fix" units in C&U grouped charts. More like hack grouped chart to look like it's working...
I am dealing with duplicate values in #40

Screenshots

Before:

screencapture-localhost-3000-host-show-10000000000017-1482244822367 1

After:
screencapture-localhost-3000-host-show-10000000000017-1482244721276

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1367560

(converted from ManageIQ/manageiq#13273)

https://bugzilla.redhat.com/show_bug.cgi?id=1401441

(cherry picked from commit b18bc4ed950bd1161d0d874a1b34655d012b84b3)
https://bugzilla.redhat.com/show_bug.cgi?id=1367560

(cherry picked from commit b2ec6ce89bdc40e9ba26fcf8f1b6f8d3eff580e0)
@miq-bot
Copy link
Member

miq-bot commented Jan 2, 2017

Checked commits PanSpagetka/manageiq-ui-classic@5b6a3ba~...a60e3c0 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. ⭐

@mzazrivec
Copy link
Contributor

@PanSpagetka What about the multiple lines in the chart showing the same value?

@dclarizio
Copy link

@mzazrivec see @PanSpagetka's line in the first comment:

I am dealing with duplicate values in #40

@mzazrivec
Copy link
Contributor

@dclarizio Yep, thanks. That line wasn't there before though.

@dclarizio
Copy link

@romanblanco does this need darga/yes flag as well?

@dclarizio dclarizio merged commit 613fea3 into ManageIQ:master Jan 6, 2017
@dclarizio dclarizio added this to the Sprint 52 Ending Jan 16, 2017 milestone Jan 6, 2017
@PanSpagetka
Copy link
Contributor Author

@dclarizio I didnt test it in darga, this bug is probably present there. But the BZ is for cfme-future so I am not sure...

@romanblanco
Copy link
Member

thanks, @PanSpagetka 😄

@dclarizio
Copy link

@PanSpagetka The bug was found in 5.6/Darga, so might need a fix there . . . I will flag the BZ for Euwe and we'll see if someone else wants it for Darga or not.

@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 1303e11f295fbe28a97e387983bd7aa8a8fcc22e
Author: Dan Clarizio <[email protected]>
Date:   Fri Jan 6 14:38:27 2017 -0800

    Merge pull request #41 from PanSpagetka/miq_pr_13273
    
    Fix units in C&U grouped charts
    (cherry picked from commit 613fea313e5964f6fda89324eb6cecdae8d309e9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1413105

@PanSpagetka PanSpagetka deleted the miq_pr_13273 branch February 14, 2017 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants