Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to add additional attributes react html tag. #4406

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Added option to add additional attributes react html tag. #4406

merged 1 commit into from
Aug 7, 2018

Conversation

Hyperkid123
Copy link
Contributor

@Hyperkid123 Hyperkid123 commented Aug 3, 2018 •
edited
Loading

Sometimes it might be required to add some additional attributes to react mounting html tag (like class for instance)

@Hyperkid123
Copy link
Contributor Author

@miq-bot add-reviewer @skateman

@miq-bot miq-bot requested a review from skateman August 3, 2018 07:34
@miq-bot
Copy link
Member

miq-bot commented Aug 3, 2018

Checked commit Hyperkid123@1cf9fb2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@Hyperkid123 Hyperkid123 mentioned this pull request Aug 3, 2018
Merged
6 tasks
skateman
skateman approved these changes Aug 3, 2018
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval
This looks very Rails-y, and I'm sure this is The Right Way™

skateman
skateman approved these changes Aug 3, 2018
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval
This looks very Rails-y, and I'm sure this is The Right Way™

skateman
skateman approved these changes Aug 3, 2018
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval
This attributes looks very Rails-y, and I'm sure this is The Right Way™

@Hyperkid123
Copy link
Contributor Author

@skateman hmm 3x approved :D this must be very special

@skateman
Copy link
Member

skateman commented Aug 3, 2018 •
edited
Loading

@Hyperkid123 yup, my terminal wanted to execute the attributes as it was in backticks.

@skateman
Copy link
Member

skateman commented Aug 3, 2018

But yes, this deserves a tripple approval 😉 and not because this was my idea :trollface:

@Hyperkid123
Copy link
Contributor Author

@miq-bot assign @martinpovolny

@martinpovolny martinpovolny merged commit 568abb8 into ManageIQ:master Aug 7, 2018
@martinpovolny martinpovolny added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 7, 2018
@Hyperkid123 Hyperkid123 deleted the attributes-to-react-tag branch November 12, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@martinpovolny martinpovolny

Labels
enhancement javascript infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hyperkid123 @miq-bot @skateman @martinpovolny