Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword Get Roles to Get Groups from Home Forest. #4425

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

jvlcek
Copy link
Member

@jvlcek jvlcek commented Aug 7, 2018

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1475891

This is a very simple PR that will clarify what is being retrieved when a checkbox is activated.

The wording of the authorization checkbox titled: Get Roles from Home Forest is confusing
for a couple of reasons.

  1. It causes Groups not Roles to be retrieved.
  2. The term Forest, although a bit misleading to AD purists, was likely chosen initially due to the similarity to the functionality for LDAP and AD. Since the term Forest has been used generically here it will stay.

The term Roles is not correct and will be changed to Groups

Steps for Testing/QA

Navigate to Configuration->Authentication and select mode LDAP or LDAPS
Check the box Get User Groups from LDAP
Note the wording of the next checkbox has been update to Get Groups from Home Forest

@jvlcek
Copy link
Member Author

jvlcek commented Aug 7, 2018

@miq-bot add_label bug

@jvlcek
Copy link
Member Author

jvlcek commented Aug 7, 2018

@miq-bot add_label settings

@jvlcek
Copy link
Member Author

jvlcek commented Aug 7, 2018

@dclarizio Can you please review or assign this to someone?

Thank you! JoeV

@miq-bot
Copy link
Member

miq-bot commented Aug 7, 2018

Checked commit jvlcek@64d01df with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 8, 2018
@mzazrivec mzazrivec merged commit d3a788e into ManageIQ:master Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants