[GAPRINDASHVILI] Move webmks console button to instance operations button mixin #4538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
changed the title
himdel
changed the title
|
LGTM, the difference from #4481 is different formatting in |
|
I've addressed rubocop and removed unnecessary comment. |
|
Checked commit https://github.com/gildub/manageiq-ui-classic/commit/5a9175e68c913d8d4936c7b0b853054457d5a164 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
This is not necessary as the button is working fine in Gaprindashvili. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is back port for Gaprindashvili for #4481
because of difference in app/helpers/application_helper/toolbar/x_vm_cloud_center.rb`.
https://bugzilla.redhat.com/show_bug.cgi?id=1622471