Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'About Modal' plugin section styling #4599

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Update 'About Modal' plugin section styling #4599

merged 1 commit into from
Sep 5, 2018

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Sep 4, 2018

This PR makes the plugin section expandable and also increases the scrollable area to 10 lines.

This is a follow-up to: #4423

screen shot 2018-09-04 at 4 45 44 pm

screen shot 2018-09-05 at 9 44 29 am

@epwinchell
Copy link
Contributor Author

@miq-bot add_label enhancement, gaprindashvili/no, formatting/styling

@epwinchell epwinchell changed the title [WIP] Update 'About Modal' plugin section styling Update 'About Modal' plugin section styling Sep 4, 2018
@miq-bot miq-bot removed the wip label Sep 4, 2018
@epwinchell
Copy link
Contributor Author

@miq-bot add_label ux/review

@epwinchell
Copy link
Contributor Author

@miq-bot assign @terezanovotna

@terezanovotna
Copy link

@epwinchell Can we make the scrollable area at least 10 lines? or even more? having to scroll in 4 lines area is not very convenient for the user. If we show 100 items, it is going to be hard to scan all the info while forever scrolling

@miq-bot
Copy link
Member

miq-bot commented Sep 5, 2018

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/17ae7998deecdbdf0b3bf47af629ecb6a447cd48 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@epwinchell
Copy link
Contributor Author

@terezanovotna Updated with 10 lines. That's already forcing a scrollbar in the viewport at 1280x800 (unless the browser is at fullscreen.) I wouldn't push it any farther.

@terezanovotna
Copy link

@epwinchell that works! You just made it more usable!

@miq-bot remove_label ux/review
@miq-bot add_label ux/approved

@epwinchell
Copy link
Contributor Author

@miq-bot assign @mzazrivec

@miq-bot miq-bot assigned mzazrivec and unassigned terezanovotna Sep 5, 2018
@mzazrivec mzazrivec added this to the Sprint 94 Ending Sep 10, 2018 milestone Sep 5, 2018
@mzazrivec mzazrivec merged commit f862e53 into ManageIQ:master Sep 5, 2018
@epwinchell epwinchell deleted the about_modal_cleanup branch March 20, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants