-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'About Modal' plugin section styling #4599
Conversation
@miq-bot add_label enhancement, gaprindashvili/no, formatting/styling |
@miq-bot add_label ux/review |
@miq-bot assign @terezanovotna |
@epwinchell Can we make the scrollable area at least 10 lines? or even more? having to scroll in 4 lines area is not very convenient for the user. If we show 100 items, it is going to be hard to scan all the info while forever scrolling |
Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/17ae7998deecdbdf0b3bf47af629ecb6a447cd48 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
@terezanovotna Updated with 10 lines. That's already forcing a scrollbar in the viewport at 1280x800 (unless the browser is at fullscreen.) I wouldn't push it any farther. |
@epwinchell that works! You just made it more usable! @miq-bot remove_label ux/review |
@miq-bot assign @mzazrivec |
This PR makes the plugin section expandable and also increases the scrollable area to 10 lines.
This is a follow-up to: #4423