Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new powerstate icons in treeview for VMs #4616

Merged
merged 2 commits into from
Sep 26, 2018

Conversation

skateman
Copy link
Member

@skateman skateman commented Sep 6, 2018

I added support for iconBackground in bootstrap-treeview, so we can use the new powerstate icons with background in the trees. This way the trees get more consistent with the quadicons and the textual summaries. Note that for VMs you should set the visibility of VM nodes under My settings.

VMs and Templates

Before:
screenshot from 2018-09-26 09-50-40
After:
screenshot from 2018-09-26 09-47-19

VM Genealogy

Before:
screenshot from 2018-09-26 09-53-39
After:
screenshot from 2018-09-26 09-54-22

Host networking

Before:
screenshot from 2018-09-26 09-57-15
After:
screenshot from 2018-09-26 09-56-41

Assigned server roles

Before:
screenshot from 2018-09-26 09-58-26
After:
screenshot from 2018-09-26 09-59-05

@miq-bot add_label gaprindashvili/no, graphics
@miq-bot add_reviewer @epwinchell

Copy link
Contributor

@epwinchell epwinchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks good.

@skateman skateman changed the title Use the new powerstate icons in treeview for VMs [WIP] Use the new powerstate icons in treeview for VMs Sep 7, 2018
@skateman
Copy link
Member Author

skateman commented Sep 7, 2018

This won't work for templates and archived VMs, marking it as wip 😞

@miq-bot miq-bot added the wip label Sep 7, 2018
@miq-bot
Copy link
Member

miq-bot commented Sep 20, 2018

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Sep 26, 2018

Checked commits skateman/manageiq-ui-classic@28cfd28~...dc73d1d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
9 files checked, 0 offenses detected
Everything looks fine. 🍪

@skateman skateman changed the title [WIP] Use the new powerstate icons in treeview for VMs Use the new powerstate icons in treeview for VMs Sep 26, 2018
@dclarizio dclarizio self-assigned this Sep 26, 2018
@dclarizio dclarizio merged commit b9d30e3 into ManageIQ:master Sep 26, 2018
@dclarizio dclarizio added this to the Sprint 96 Ending Oct 8, 2018 milestone Sep 26, 2018
@skateman skateman deleted the treeview-powerstate branch September 26, 2018 18:00
simaishi pushed a commit that referenced this pull request Oct 1, 2018
Use the new powerstate icons in treeview for VMs

(cherry picked from commit b9d30e3)
@simaishi
Copy link
Contributor

simaishi commented Oct 1, 2018

Hammer backport details:

$ git log -1
commit 5a949290f4fd207a7d4d78cc6066a2cc3bd43e10
Author: Dan Clarizio <[email protected]>
Date:   Wed Sep 26 10:58:43 2018 -0700

    Merge pull request #4616 from skateman/treeview-powerstate
    
    Use the new powerstate icons in treeview for VMs
    
    (cherry picked from commit b9d30e3b9827c5b6877b13be6c9fad5ebf0a4d82)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants