-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new powerstate icons in treeview for VMs #4616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Looks good.
This won't work for templates and archived VMs, marking it as wip 😞 |
This pull request is not mergeable. Please rebase and repush. |
a068fb3
to
dc73d1d
Compare
Checked commits skateman/manageiq-ui-classic@28cfd28~...dc73d1d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Use the new powerstate icons in treeview for VMs (cherry picked from commit b9d30e3)
Hammer backport details:
|
I added support for
iconBackground
in bootstrap-treeview, so we can use the new powerstate icons with background in the trees. This way the trees get more consistent with the quadicons and the textual summaries. Note that for VMs you should set the visibility of VM nodes underMy settings
.VMs and Templates
Before:
![screenshot from 2018-09-26 09-50-40](https://user-images.githubusercontent.com/649130/46065156-a811bc80-c171-11e8-891f-cb746ca92bac.png)
![screenshot from 2018-09-26 09-47-19](https://user-images.githubusercontent.com/649130/46065121-8dd7de80-c171-11e8-91bf-729a15adb668.png)
After:
VM Genealogy
Before:
![screenshot from 2018-09-26 09-53-39](https://user-images.githubusercontent.com/649130/46065339-1ce4f680-c172-11e8-813c-4c435fbe7b55.png)
![screenshot from 2018-09-26 09-54-22](https://user-images.githubusercontent.com/649130/46065356-29694f00-c172-11e8-8e40-d1fee80acfbe.png)
After:
Host networking
Before:
![screenshot from 2018-09-26 09-57-15](https://user-images.githubusercontent.com/649130/46065536-94b32100-c172-11e8-804a-419e7c5bb41a.png)
![screenshot from 2018-09-26 09-56-41](https://user-images.githubusercontent.com/649130/46065542-98df3e80-c172-11e8-86d0-4a4acda8b7ab.png)
After:
Assigned server roles
Before:
![screenshot from 2018-09-26 09-58-26](https://user-images.githubusercontent.com/649130/46065602-c88e4680-c172-11e8-8ee6-1033a0d6d6be.png)
![screenshot from 2018-09-26 09-59-05](https://user-images.githubusercontent.com/649130/46065616-d348db80-c172-11e8-8134-09124479318d.png)
After:
@miq-bot add_label gaprindashvili/no, graphics
@miq-bot add_reviewer @epwinchell