Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add any product product feature for Customization in menu #4782

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Add any product product feature for Customization in menu #4782

merged 1 commit into from
Nov 2, 2018

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Oct 16, 2018 •
edited
Loading

depending on:

  • missing PR

part of issue ManageIQ/manageiq#18100

display menu Customization if any product feature is checked
screenshot 2018-10-16 at 16 26 33

and now is enough just to have checked Dialogs

screenshot 2018-10-16 at 16 29 34

Links

*https://bugzilla.redhat.com/show_bug.cgi?id=1297415

@lpichler lpichler changed the title Add any product product feature for Customization in menu [WIP] Add any product product feature for Customization in menu Oct 16, 2018
@miq-bot miq-bot added the wip label Oct 16, 2018
@lpichler lpichler mentioned this pull request Oct 16, 2018
Closed
9 tasks
@miq-bot
Copy link
Member

miq-bot commented Oct 16, 2018

Checked commit lpichler@fd6ede8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@JPrause
Copy link
Member

JPrause commented Oct 24, 2018

@miq-bot add_label blocker

@JPrause
Copy link
Member

JPrause commented Oct 30, 2018

Since there hasn't been an update in two weeks, @lpichler can you provide a current update on this issue.

@lpichler lpichler changed the title [WIP] Add any product product feature for Customization in menu Add any product product feature for Customization in menu Oct 31, 2018
@lpichler lpichler closed this Oct 31, 2018
@lpichler lpichler reopened this Oct 31, 2018
@lpichler lpichler force-pushed the allow_any_product_feature_for_customization branch from fd6ede8 to bcc6044 Compare November 1, 2018 09:56
@lpichler lpichler closed this Nov 1, 2018
@lpichler lpichler reopened this Nov 1, 2018
@lpichler
Copy link
Contributor Author

lpichler commented Nov 1, 2018

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Nov 1, 2018
@mzazrivec mzazrivec self-assigned this Nov 2, 2018
@mzazrivec mzazrivec added this to the Sprint 98 Ending Nov 5, 2018 milestone Nov 2, 2018
@mzazrivec mzazrivec merged commit a3a9ce7 into ManageIQ:master Nov 2, 2018
@lpichler lpichler deleted the allow_any_product_feature_for_customization branch November 2, 2018 12:44
@lpichler
Copy link
Contributor Author

lpichler commented Nov 2, 2018

@miq-bot remove_label gapridashvili/yes
@miq-bot remove_label hammer/yes

BZ is for 5.11

@miq-bot
Copy link
Member

miq-bot commented Nov 2, 2018

@lpichler Cannot remove the following label because they are not recognized: gapridashvili/yes

@miq-bot miq-bot removed the hammer/yes label Nov 2, 2018
@lpichler
Copy link
Contributor Author

lpichler commented Nov 2, 2018

@miq-bot remove_label gaprindashvili/yes

simaishi pushed a commit that referenced this pull request Nov 15, 2018
@mzazrivec @simaishi
Merge pull request #4782 from lpichler/allow_any_product_feature_for_…
f1e8c8a 
…customization

Add any product product feature for Customization in menu

(cherry picked from commit a3a9ce7)

https://bugzilla.redhat.com/show_bug.cgi?id=1297415
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit f1e8c8a1a855f9a82bcd23b95e4d9eac3d0aae6b
Author: Milan Zázrivec <[email protected]>
Date:   Fri Nov 2 12:32:22 2018 +0100

    Merge pull request #4782 from lpichler/allow_any_product_feature_for_customization
    
    Add any product product feature for Customization in menu
    
    (cherry picked from commit a3a9ce7b53273e19f44dc042b3fe3950c050686a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1297415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpovolny martinpovolny Awaiting requested review from martinpovolny

Assignees

@mzazrivec mzazrivec

Labels
blocker bug hammer/backported menus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpichler @miq-bot @JPrause @simaishi @mzazrivec