GTL - use miqSparkle-style spinner when loading

[himdel]

this changes the GTL spinner code to show the ManageIQ spinner when the content is loading
this should prevent timing issues when trying to switch views (tree_select) when a GTL view is being loaded

using ManageIQ.gtl.loading in miqSparkleOff is ...sub-optimal,
but I'm currently seeing no way not to do that without the spinner disappearing and reapearring when the ajax request finishes but before the angular gtl code finishes initializing

Probably needs quite some testing :).

https://bugzilla.redhat.com/show_bug.cgi?id=1626627

[himdel]

Cc @hstastna (because that BZ)

[hstastna]

I am ok with this PR, but not able to recreate the BZ, too. But @h-kataria I think you were able to recreate the BZ. Maybe you could also to test this PR 😏 Maybe also @kbrock Thanks! ❇️

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/825a368705fb19e7ab66278c5c948c6c1e96fbcc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[h-kataria]

@himdel i was not able to recreate on upstream, was only randomly able to recreate on Gaprindashvili. But i have tested this on several explorer screen with and without some sleep statements in code, seems to be working good. Should this be marked as Gaprindashvili/yes ?

[h-kataria]

@himdel can you knock down code climate issues? other then those i am good with merging this PR.

[himdel]

@h-kataria Aah, good catch, added gaprindashvili/yes :).

Re CC, I don't see a good way of fixing those...

I don't think doing

  ReportDataController.prototype.loading = function(loading) {
    this.$window.ManageIQ.gtl.loading = loading;
    this.settings.isLoading = loading;
    loading ? miqSparkleOn() : miqSparleOff();
  };

increases readability much, do you?

[dclarizio]

@himdel how about something like this, a little clearer (I even fixed your typo):

  ReportDataController.prototype.setLoadingState = function(state) {
    this.$window.ManageIQ.gtl.loading = state;
    this.settings.isLoading = state;
    state ? miqSparkleOn() : miqSparkleOff();
  };

[himdel]

(removed because setDefaults is only called from the same getData response handler as that setLoading in $timeout above, but too early because no timeout)

[himdel]

Ok ok, fixed & rebased :)

[simaishi]

Hammer backport details:

$ git log -1
commit 9f47c18cdc37c74aa4bf0597f9efb16a514083cc
Author: Harpreet Kataria <[email protected]>
Date:   Thu Nov 1 15:51:02 2018 -0400

    Merge pull request #4844 from himdel/gtl-loader
    
    GTL - use miqSparkle-style spinner when loading
    
    (cherry picked from commit 249138c4ea4227cb98c572b1914259275274bd72)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1626627