Allow a maximum of 500 characters in a service dialog text box #4869
Conversation
…ad of 50 The service dialog text box is too short. This is bothering people for years now: ManageIQ/manageiq#1226. The best solution would be to add a 'maxlength' option to the dialog editor but the hereby proposed solution would make it workeable and would prevent people using a Text Area where they would prefer a text Box just because of the enforced maxlength of 50 characters for the text Box.
|
Checked commits https://github.com/kruge002/manageiq-ui-classic/compare/f7ebc89851470d7c9ea14c43cc05e541c185dd8b~...c898bd9ad9da89038abaefe0490c170cd0f67ceb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@kruge002 Could you send steps (or even screenshots) to reproduce the issue you're trying to fix? The issue ManageIQ/manageiq#1226 seems to describe the old version of Dialog Editor, where the limit was probably applied. Code for the new Dialog Editor lives in ui-components repository: as well as the Dialog User - component, that renders the dialogs: where no such limit seems to be applied. EDIT: The code seems to be used for provisioning, and not editing the service dialog. Looks like we still use the old templates together with the new Dialog User. Still, steps to reproduce would help |
|
cc @gmcculloug as you pinned the original issue. |
|
@gmcculloug , @romanblanco : what's the status of this PR? |
|
@kruge002, any update? |
|
I have created a service dialog in the Hammer release and currently there is no maximum length issue for a text field. So this PR can be closed. This PR was meant for the Fine release. |
The service dialog text box has a maxlength of 50. This is too short. This is bothering people for years now: ManageIQ/manageiq#1226.
The best solution would be to add a 'maxlength' option to the dialog editor but the hereby proposed solution would make it workeable and would prevent people using a Text Area where they would prefer a text Box just because of the enforced maxlength of 50 characters for the text Box.