Add X-UA-Compatible header #4946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in situations where IE11 fails to detect the "document mode" correctly, this header should ensure that IE uses the "edge" mode. (this probably doesn't help in any case where IE11 is set to force IE7 mode) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1648338
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/2304073aa34e9f3dcb0b910644112c7388493b1f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
cc @martinpovolny .. if you have any idea where this could autodetect wrong and test that this helps... |
simaishi
pushed a commit
that referenced
this pull request
Nov 26, 2018
Add X-UA-Compatible header (cherry picked from commit 123d000) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1648338
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2018
Add X-UA-Compatible header (cherry picked from commit 123d000) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1653710
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in situations where IE11 fails to detect the "document mode" correctly,
this header should ensure that IE uses the "edge" mode.
(this probably doesn't help in any case where IE11 is set to force IE7 mode)
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1648338
But see the comments in the BZ,
I'm almost sure this is useless, because the problem is not on our side. It won't hurt though, and will fix the problem if I'm wrong :)EDIT: confirmed in the BZ that this header will indeed override group policy settings