Show also non vpc vms in network topology

[Ladas]

Depends on:

• We need a placeholder availability_zones method for network topology manageiq#14161

In AWS, EC2 classic Vms do not have a subnet associated, so
these would not show in the topology. By allowing the Vms to
be shown also under Availability Zone, we should be showing all
Vms in the system.

Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1400087

[Ladas]

before:

after:

[miq-bot]

Checked commits Ladas/manageiq-ui-classic@1279fe5~...d669904 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 5 offenses detected

spec/services/network_topology_service_spec.rb

• ❕ - Line 159, Col 121 - Metrics/LineLength - Line is too long. [124/120]
• ❕ - Line 160, Col 121 - Metrics/LineLength - Line is too long. [122/120]
• ❕ - Line 256, Col 121 - Metrics/LineLength - Line is too long. [134/120]
• ❕ - Line 258, Col 121 - Metrics/LineLength - Line is too long. [122/120]
• ❕ - Line 7, Col 121 - Metrics/LineLength - Line is too long. [190/120]

[mzazrivec]

Things work OK for Amazon, but I'm getting the following error for an OpenStack topology
which isn't there when I try the same thing on master:

FATAL -- : Error caught: [NoMethodError] undefined method `compressed_id' for #<ActiveRecord::Relation []>
.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.2/lib/active_record/relation/delegation.rb:124:in `method_missing'
.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.2/lib/active_record/relation/delegation.rb:94:in `method_missing'
app/services/topology_service.rb:35:in `entity_id'
app/services/topology_service.rb:75:in `build_rel_data_and_links'
app/services/topology_service.rb:64:in `block in build_recursive_topology'
app/services/topology_service.rb:56:in `each'
app/services/topology_service.rb:56:in `build_recursive_topology'
app/services/network_topology_service.rb:48:in `block in build_topology'
.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.2/lib/active_record/relation/delegation.rb:38:in `each'
.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.2/lib/active_record/relation/delegation.rb:38:in `each'
app/services/network_topology_service.rb:47:in `build_topology'
app/controllers/topology_controller.rb:49:in `generate_topology'
app/controllers/topology_controller.rb:35:in `data'

[Ladas]

@mzazrivec core fix added as a dependency

[Ladas]

@mzazrivec can you recheck this? The core dependency was merged

[simaishi]

Euwe backport (to manageiq repo) details:

$ git log -1
commit 6d0a92fcf44cd229749a640d9c8cb3a70d648173
Author: Milan Zázrivec <[email protected]>
Date:   Thu Mar 9 11:31:03 2017 +0100

    Merge pull request #510 from Ladas/show_also_non_vpc_vms_in_network_topology
    
    Show also non vpc vms in network topology
    (cherry picked from commit 1d53014f8b98c5d60e2ebe775f79b460bade14c7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1431163