set_ownership - use miq_template (not vm) for images #5113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, clicking the Set Ownership button on a nested list of images under a cloud provider redirects to `/vm/ownership`. But image is not a vm, it's a template, so the url should be `/miq_template/ownership`. The difference causes 2 bugs: * (hammer only: no form buttons are shown) * affected items shows No records found Fixing to use miq_template. https://bugzilla.redhat.com/show_bug.cgi?id=1650507 (related but that bug is not present on master)
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/76ce52072996dbd77331c165896f620e00120597 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Restarting travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, clicking the Set Ownership button on a nested list of images under a cloud provider redirects to
/vm/ownership.But image is not a vm, it's a template, so the url should be
/miq_template/ownership.The difference causes 2 bugs:
no form buttons are shown(only in hammer, Replaces angular ownership form with data-driven-form #5046 replaced it on master) (=> [HAMMER] set_ownership - use miq_template (not vm) for images #5112)Fixing to use miq_template.
(related to https://bugzilla.redhat.com/show_bug.cgi?id=1650507, but the BZ only talks about the form buttons)
Before:
After: