Show affected servers on PhysicalServerProvisionRequest details #5461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
mzazrivec
reviewed
Apr 16, 2019
| @@ -0,0 +1,7 @@ | |||
| #main_div | |||
| %h3 | |||
| = _("Affected PhysicalServers") | |||
There was a problem hiding this comment.
Affected PhysicalServers ➛ Affected Physical Servers right?
Currenlty, PhysicalServerProvisionDetails page was trying to fetch and display Vms with given src_ids, instead PhysicalServers. With this commit we make sure it displays the corret model. Signed-off-by: Miha Pleško <[email protected]>
miha-plesko
force-pushed
the
physical-provision-request
branch
from
297a103 to
1d9950f
Compare
|
Some comments on commit xlab-si@1d9950f spec/controllers/miq_request_controller_spec.rb
|
|
Checked commit xlab-si@1d9950f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, PhysicalServerProvision details page was trying to fetch and display affected VMs (with given src_ids), instead PhysicalServers. With this commit we make sure it displays the correct model, see screenshot below:
@miq-bot add_label enhancement
@miq-bot assign @mzazrivec
(assigning @mzazrivec since he merged a very similar PR some time ago when we were fixing it for service retirement, see #4710)