-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open the homonymic tree nodes for dialog editor entrypoint selection #5543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ebd8c2
to
38c2cc8
Compare
romanblanco
reviewed
May 9, 2019
e6d031b
to
82b091f
Compare
82b091f
to
ff35fe1
Compare
Checked commits skateman/manageiq-ui-classic@71d635f~...ff35fe1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
romanblanco
approved these changes
May 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works.
LGTM 👍
@miq-bot rm_label pending core |
@miq-bot assign @mzazrivec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dialog editor has an option to set a field dynamic, if this is enable there's an entry point selection tree available under the Options tab. If you're editing an already existing field with an entry point selected, the tree nodes to the entry point aren't expanded.
However, the entry point doesn't include a domain prefix, it is possible that the same entry point is available under a different domain. We discussed this with the automate folks and the only solution is to expand all the homonymic nodes under all possible automate domain prefixes.
I added an optional block evaluation to the
TreeController#fetch_tree
method that runs before the tree is being build. By passing a block to this method, we can easily define different behavior for certain trees without defining extra arguments for the method. We might want to redesign this block evaluation in the future to run directly in theTreeBuilder
but for now it is good as it is.Depends on: ManageIQ/manageiq#18722
@miq-bot add_reviewer @martinpovolny
@miq-bot add_reviewer @himdel
@miq-bot add_reviewer @romanblanco
@miq-bot add_label pending core, changelog/yes, angular dialogs, automation/automate, trees