Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open the homonymic tree nodes for dialog editor entrypoint selection #5543

Merged
merged 4 commits into from
May 22, 2019

Conversation

skateman
Copy link
Member

@skateman skateman commented May 7, 2019

The dialog editor has an option to set a field dynamic, if this is enable there's an entry point selection tree available under the Options tab. If you're editing an already existing field with an entry point selected, the tree nodes to the entry point aren't expanded.

However, the entry point doesn't include a domain prefix, it is possible that the same entry point is available under a different domain. We discussed this with the automate folks and the only solution is to expand all the homonymic nodes under all possible automate domain prefixes.

I added an optional block evaluation to the TreeController#fetch_tree method that runs before the tree is being build. By passing a block to this method, we can easily define different behavior for certain trees without defining extra arguments for the method. We might want to redesign this block evaluation in the future to run directly in the TreeBuilder but for now it is good as it is.

Depends on: ManageIQ/manageiq#18722

@miq-bot add_reviewer @martinpovolny
@miq-bot add_reviewer @himdel
@miq-bot add_reviewer @romanblanco
@miq-bot add_label pending core, changelog/yes, angular dialogs, automation/automate, trees

@skateman skateman force-pushed the automate-tree-fqdn branch 2 times, most recently from e6d031b to 82b091f Compare May 9, 2019 18:09
@skateman skateman force-pushed the automate-tree-fqdn branch from 82b091f to ff35fe1 Compare May 10, 2019 04:53
@miq-bot
Copy link
Member

miq-bot commented May 10, 2019

Checked commits skateman/manageiq-ui-classic@71d635f~...ff35fe1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works.
LGTM 👍

@skateman
Copy link
Member Author

@miq-bot rm_label pending core

@skateman
Copy link
Member Author

@miq-bot assign @mzazrivec

@mzazrivec mzazrivec added this to the Sprint 112 Ending May 27, 2019 milestone May 22, 2019
@mzazrivec mzazrivec merged commit d62b990 into ManageIQ:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants