Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix catalog item delete when part of catalog bundle #5750

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

mzazrivec
Copy link
Contributor

  1. Create catalog item catalog01
  2. Create catalog bundle bundle01 with catalog01 in it
  3. Try to delete catalog01 in UI

Previously, the UI would report successful deletion, although in truth no deletion would take place. In this particular case, for the delete request the API returns http/200 and the following JSON:

{"success":false,"message":"Cannot delete a service that is the child of another service."}

so we need to adjust our code accordingly.

With the proposed fix in place:
catalog-item-delete

https://bugzilla.redhat.com/show_bug.cgi?id=1356086

@mzazrivec mzazrivec force-pushed the fix_catalog_item_delete branch from 8b20e91 to bb0162c Compare June 27, 2019 08:29
@miq-bot
Copy link
Member

miq-bot commented Jul 2, 2019

Checked commit mzazrivec@bb0162c with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@h-kataria h-kataria self-assigned this Jul 8, 2019
@h-kataria h-kataria added this to the Sprint 115 Ending Jul 8, 2019 milestone Jul 8, 2019
@h-kataria h-kataria merged commit ec487e2 into ManageIQ:master Jul 8, 2019
@mzazrivec mzazrivec deleted the fix_catalog_item_delete branch July 9, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants