Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate method editing bugz #5843

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Automate method editing bugz #5843

merged 2 commits into from
Jul 22, 2019

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Jul 22, 2019 •
edited
Loading

bz: https://bugzilla.redhat.com/show_bug.cgi?id=1678150
https://bugzilla.redhat.com/show_bug.cgi?id=1729999

also fixes a regression when editing automate methods:

[----] I, [2019-07-22T13:02:30.442810 #23250:57bee40]  INFO -- :   Rendered /home/martin/Projects/manageiq-ui-classic/app/views/miq_ae_class/_all_tabs.html.haml (235.7ms)                                         
[----] F, [2019-07-22T13:02:30.444149 #23250:57bee40] FATAL -- : Error caught: [ActionView::Template::Error] undefined method `[]' for nil:NilClass                                                               
/home/martin/Projects/manageiq-ui-classic/app/views/layouts/angular/_ansible_form_options_angular.html.haml:36:in `__home_martin__rojects_manageiq_ui_classic_app_views_layouts_angular__ansible_form_options_angul
ar_html_haml__664314731155744517_69949740029940'                                                                                                                                                                  
/home/martin/.rvm/gems/ruby-2.5.5/gems/actionview-5.1.7/lib/action_view/template.rb:157:in `block in render'                                                                                                      
/home/martin/.rvm/gems/ruby-2.5.5/gems/activesupport-5.1.7/lib/active_support/notifications.rb:168:in `instrument'                                                                                                
/home/martin/.rvm/gems/ruby-2.5.5/gems/actionview-5.1.7/lib/action_view/template.rb:352:in `instrument_render_template'                                                                                           
/home/martin/.rvm/gems/ruby-2.5.5/gems/actionview-5.1.7/lib/action_view/template.rb:155:in `render'                                                                                                               
/home/martin/.rvm/gems/ruby-2.5.5/gems/actionview-5.1.7/lib/action_view/renderer/partial_renderer.rb:342:in `block in render_partial'                                                                              
/home/martin/.rvm/gems/ruby-2.5.5/gems/actionview-5.1.7/lib/action_view/renderer/abstract_renderer.rb:42:in `block in instrument'                                                                                 
/home/martin/.rvm/gems/ruby-2.5.5/gems/activesupport-5.1.7/lib/active_support/notifications.rb:166:in `block in instrument'
/home/martin/.rvm/gems/ruby-2.5.5/gems/activesupport-5.1.7/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/home/martin/.rvm/gems/ruby-2.5.5/gems/activesupport-5.1.7/lib/active_support/notifications.rb:166:in `instrument'     
/home/martin/.rvm/gems/ruby-2.5.5/gems/actionview-5.1.7/lib/action_view/renderer/abstract_renderer.rb:41:in `instrument'
/home/martin/.rvm/gems/ruby-2.5.5/gems/actionview-5.1.7/lib/action_view/renderer/partial_renderer.rb:331:in `render_partial'         
/home/martin/.rvm/gems/ruby-2.5.5/gems/actionview-5.1.7/lib/action_view/renderer/partial_renderer.rb:310:in `render'             
/home/martin/.rvm/gems/ruby-2.5.5/gems/actionview-5.1.7/lib/action_view/renderer/renderer.rb:47:in `render_partial'        
/home/martin/.rvm/gems/ruby-2.5.5/gems/actionview-5.1.7/lib/action_view/renderer/renderer.rb:21:in `render'                                                                                                       
/home/martin/.rvm/gems/ruby-2.5.5/gems/actionview-5.1.7/lib/action_view/helpers/rendering_helper.rb:31:in `render'                                                                                                
/home/martin/Projects/manageiq-ui-classic/app/views/miq_ae_class/_angular_method_form.html.haml:51:in `__home_martin__rojects_manageiq_ui_classic_app_views_miq_ae_class__angular_method_form_html_haml__4544691709
638769177_72572040'

@martinpovolny martinpovolny requested a review from h-kataria July 22, 2019 11:03
@miq-bot
Copy link
Member

miq-bot commented Jul 22, 2019

Checked commits martinpovolny/manageiq-ui-classic@2a6f089~...697f454 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@h-kataria h-kataria self-assigned this Jul 22, 2019
@h-kataria h-kataria merged commit 1a361bb into ManageIQ:master Jul 22, 2019
simaishi pushed a commit that referenced this pull request Aug 14, 2019
@h-kataria @simaishi
Merge pull request #5843 from martinpovolny/automate_bz_1714632
c5c4375 
Automate method editing bugz

(cherry picked from commit 1a361bb)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1740769
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit c5c4375abe95c5c988358bf060e0c6a332761505
Author: Harpreet Kataria <[email protected]>
Date:   Mon Jul 22 11:12:28 2019 -0400

    Merge pull request #5843 from martinpovolny/automate_bz_1714632
    
    Automate method editing bugz
    
    (cherry picked from commit 1a361bb4b5c1be79519059ef0d03e3bb99bd7ea9)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1740769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-kataria h-kataria h-kataria approved these changes

Assignees

@h-kataria h-kataria

Labels
automation/automate bug changelog/yes hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinpovolny @miq-bot @simaishi @h-kataria