Switch to Advanced tab when only error is "Request is required"

[ZitaNemeckova]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1717843

Go to Automation -> Automate -> Customization -> Buttons -> Configuration -> Add/Edit a Button -> make sure Request in Advanced tab is empty and Text, Hover Text, Icon in Options are set -> click Add/Save

First commit fixes the bug, other commits just clean around a bit.

Before:

After:

@miq-bot add_label bug, automation/automate, ivanchuk/yes, hammer/yes

@h-kataria please have a look, thanks :)

[ZitaNemeckova]

@h-kataria Fixed. Please re-review, thanks :)

[h-kataria]

@ZitaNemeckova minor issue found,
Add a new button, enter some text, hover text, choose a button icon, press Add button, this will show a flash message "Request is required" and make Advacned tab active. Now press "Define Expression" button this will switch tab back to "Options" tab, user should remain on "Advanced" tab after Define Expression is pressed

[ZitaNemeckova]

@h-kataria I cannot reproduce it :/ For me it stays on Advanced tab.

[romanblanco]

@ZitaNemeckova minor issue found,
Add a new button, enter some text, hover text, choose a button icon, press Add button, this will show a flash message "Request is required" and make Advacned tab active. Now press "Define Expression" button this will switch tab back to "Options" tab, user should remain on "Advanced" tab after Define Expression is pressed

@ZitaNemeckova, the same happens to me

[ZitaNemeckova]

@romanblanco @h-kataria sorry my local branch and this PR were not in sync. I pushed my changes and now it should work well.

[romanblanco]

Tested, works 👍

[h-kataria]

@ZitaNemeckova test failures look related to changes in this PR

[miq-bot]

Checked commits ZitaNemeckova/manageiq-ui-classic@a0760fc~...47b25af with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[simaishi]

Ivanchuk backport details:

$ git log -1
commit 907631a0294372ae6f50eba735a349b81f2b3caa
Author: Harpreet Kataria <[email protected]>
Date:   Wed Aug 7 11:41:32 2019 -0400

    Merge pull request #5873 from ZitaNemeckova/fix_cb_tabs
    
    Switch to Advanced tab when only error is "Request is required"
    
    (cherry picked from commit 88b4b54e8c037eab2114233538f45eedcf7e6520)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1717843