Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show value of Locked/Reset fields when value is false or not set. #5900

Conversation

h-kataria
Copy link
Contributor

  • Changed to show Yes/No values for better readability

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1733555

before
before1

after
after1

@miq-bot
Copy link
Member

miq-bot commented Jul 29, 2019

Checked commit h-kataria@0cd10fe with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec added this to the Sprint 117 Ending Aug 5, 2019 milestone Jul 30, 2019
@mzazrivec mzazrivec merged commit 54a6c20 into ManageIQ:master Jul 30, 2019
simaishi pushed a commit that referenced this pull request Jul 30, 2019
…hboard_summary

Show value of Locked/Reset fields when value is false or not set.

(cherry picked from commit 54a6c20)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1733555
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit ac90d07b631e9f536969f775734153f2bc00b130
Author: Milan Zázrivec <[email protected]>
Date:   Tue Jul 30 12:03:41 2019 +0200

    Merge pull request #5900 from h-kataria/fix_boolean_value_display_dashboard_summary
    
    Show value of Locked/Reset fields when value is false or not set.
    
    (cherry picked from commit 54a6c2093c61abaf6888d939cdca3dfdefa1bc09)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1733555

@h-kataria h-kataria deleted the fix_boolean_value_display_dashboard_summary branch August 1, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants