Propagate parent model into GTLs on InfraNetwork switches 🖵 🐞

[skateman]

The GTL on the Compute > Infrastructure -> Networking displays the same switches all the time, doesn't matter which node you are selecting. The problem is that the selected_ids param is no longer propagated into the GTLs. Even if I would try to propagate it, an empty array would fall back to the current behavior (possibly because of a compact on the params somewhere).

The Right Way™ is to send the parent record into the options passed further to the GTL and it will automagically call the switches method on it. Of course this requires to have the switches method on every model we're touching and it's missing from the EmsCluster.

Also found out that the Lan nodes under switches should not be clickable, we lost this functionality here.

@miq-bot add_label pending core, bug, compute/infrastructure, explorers, hammer/yes, ivanchuk/yes
@miq-bot add_reviewer @h-kataria

Depends on: ManageIQ/manageiq#19076
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1726280

[skateman]

@h-kataria there's still a glitch with this, I'm not sure if we would like to display the switches that don't belong to any host. The TreeBuilder apparently ignores them and I'd go with it as a reference and hide them using the already existing shareable named scope. If we'd like to display them, we might need some extra model changes.

Let's discuss this on gitter when you're available ...

[skateman]

@miq-bot rm_label pending core

[miq-bot]

Checked commits skateman/manageiq-ui-classic@a9f371a~...4ba6f1b with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[simaishi]

Ivanchuk backport details:

$ git log -1
commit 6cd24042412810204ad497c7cd3ba10dfe5ec17c
Author: Harpreet Kataria <[email protected]>
Date:   Tue Jul 30 16:31:48 2019 -0400

    Merge pull request #5902 from skateman/switches-controller
    
    Propagate parent model into GTLs on InfraNetwork switches 🖵 🐞
    
    (cherry picked from commit c6130750863bc1d6ed88710fdd7ffb27e944370e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1726280