Broken endpoint fix for dialog from GO instance detail page #6049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkomanek
force-pushed
the
generic_object_dialog_endpoint_fix
branch
from
55b40bf to
ec83744
Compare
pkomanek
changed the title
|
Checked commit pkomanek@ec83744 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@pkomanek do we need to fix endpoint url here https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/services/dialog_local_service.rb#L40 |
| else | ||
| # Determine related service ID for selected GO | ||
| @breadcrumbs.last[:url][/\/\d*\?/][1..-2] | ||
| end |
There was a problem hiding this comment.
We should not determine ID from breadcrumbs :-(
There was a problem hiding this comment.
Breadcrumbs are a presentation "detail". The should not be used to determine what's an ID of an object we are going to work with.
Such code is guaranteed to cause regression. Not now. But once someone tries to actually fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing broken endpoint for dialog from GenericObject(GO) detail page. As we can see from logs in BZ, endpoint url contains GO ID instead of related Service ID. In the case where there is no such a service with same ID as GO, you will get the error.
Links
Steps for Testing/QA
Steps are included in the BZ above