Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for unable to import service dialog from yaml #616

Merged
merged 1 commit into from
Mar 10, 2017
Merged

Fix for unable to import service dialog from yaml #616

merged 1 commit into from
Mar 10, 2017

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Mar 7, 2017

Makes helper methods accessible.

https://bugzilla.redhat.com/show_bug.cgi?id=1429964

@eclarizio
Copy link
Member

@martinpovolny Any idea why we would need to explicitly extend the helper here instead of the methods just being available to use in the view? I feel like while extending it technically solves the BZ, we shouldn't need to do that and it may be a symptom of a different issue.

@martinpovolny
Copy link
Member

I'd day that app/controllers/miq_ae_customization_controller.rb should include the line:

helper ApplicationHelper::ImportExportHelper

instead of the changes seen here

@miq-bot
Copy link
Member

miq-bot commented Mar 7, 2017

Checked commit d-m-u@07795e8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@gmcculloug
Copy link
Member

@martinpovolny Please review/merge.

@mzazrivec mzazrivec added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 10, 2017
@mzazrivec mzazrivec merged commit 7d965b6 into ManageIQ:master Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants