[HAMMER] Dropbox removed, in exchange for using support tool

[jrafanie]

Manual backport of #6330 and #6341

Make both red hat dropbox and support tool read-only

https://bugzilla.redhat.com/show_bug.cgi?id=1765635

Note, there's still test files referencing the changed dropbox strings but #6330 passed tests and didn't include them. If needed, we can do another upstream PR for master/hammer to get them:

02:38:05 ~/Code/manageiq-ui-classic (hammer_backport_6330_dropbox_out_support_tool_in) (2.6.5) - git grep "Red Hat Dropbox"
spec/javascripts/controllers/ops/log_collection_form_controller_spec.js:        depot_name: 'Red Hat Dropbox',
spec/javascripts/controllers/ops/log_collection_form_controller_spec.js:        vm.logCollectionModel.log_protocol = 'Red Hat Dropbox';
spec/javascripts/controllers/ops/log_collection_form_controller_spec.js:        $httpBackend.whenGET('/ops/log_protocol_changed/123456?log_protocol=Red Hat Dropbox').respond(200, logProtocolChangedFormResponse);
0

[jrafanie]

cc @simaishi

[jrafanie]

cc @juliancheal

[himdel]

Soo... what this change does is allow users to edit their existing Red Hat Dropbox log settings.
Is that the intent? Or am I missing a migration/backend change to translate the log_protocol value somewhere?

[juliancheal]

@himdel Ah sorry for the confusion. We were doing two things with one PR. RH Dropbox has been removed from downstream, and replaced with the file depo, with the settings for that not being editable. :)

[himdel]

Ah, thanks, ok, as long as the backend is dealing with this.. :)

👍

(we probably should fix those remaining mentions in master, but that's for another pr :))

[juliancheal]

@himdel Having spoken with @jrafanie et al, we've made a suppliment for this PR #6341 which still keeps RH Dropbox, as well as adding RH Support.

FYI, yes I fully agree this being upstream is not ideal, but that's tomorrows problem :)

[jrafanie]

Hold off on merging, I'm pushing one other change to match the changes in #6341

[miq-bot]

Checked commit jrafanie@855d7a1 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

app/views/ops/_log_collection.html.haml

• ⚠️ - Line 40 - Line is too long. [176/160]