Make Save button respond properly on changes in User's Available Groups #6369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstastna
force-pushed
the
Save_button_respond_UsersAvailableGroups
branch
4 times, most recently
from
01fdd94 to
f78f323
Compare
|
@hstastna The issue with Save button is still present in this PR. PR is fixing Ordering. |
hstastna
force-pushed
the
Save_button_respond_UsersAvailableGroups
branch
from
f78f323 to
827a121
Compare
|
Moving this PR to WIP as it fixes the issue only for some situations, not always. |
hstastna
changed the title
hstastna
force-pushed
the
Save_button_respond_UsersAvailableGroups
branch
3 times, most recently
from
d0d4801 to
f0cdb80
Compare
hstastna
changed the title
|
@miq-bot add_reviewer @ZitaNemeckova |
|
Tested in UI. LGTM 👍 |
added 2 commits
November 27, 2019 11:34
Also remove unnecessary code from _rbac_group_selected.html.haml.
hstastna
force-pushed
the
Save_button_respond_UsersAvailableGroups
branch
from
f0cdb80 to
4ada34d
Compare
|
Checked commits hstastna/manageiq-ui-classic@2003cd8~...4ada34d with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Re-tested. LGTM 👍 |
|
Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6364
In User's editing screen, Save button wasn't responding properly on changes in Available Groups section, especially if there were more groups selected in the drop down.
Another issue was improper order of groups in Selected Groups section while adding/editing User. It was inconsistent with the User's details screen where the Groups are properly ordered (by description).
This PR fixes both issues, together with fixing two improper comments in the code.
Details:
The improper response of Save butto on changes in User's Available Groups was caused by sorting the Groups' ids represented by array of strings. We need to put the ids from strings to integers AND THEN to sort the array of ids. We need to have ids in both
@edit[:new][:group]and@edit[:current][:group]sorted to be able to compare them and then to setchangedvariable properly, for proper response of Save button.The second issue is fixed simply by adding
.sortto the array of descriptions of selected groups. I've also removed unnecessary code in the same haml, as@edit[:new][:group]is already edited here before it is used in the haml, so no need to do the same stuff again in the haml, I mean splitting the string (@edit[:new][:group]is already an array of integers in the haml, not string!), and checking for'null'.User's details screen, check the Groups and their order - groups are alphabetically orderd:
Before: bad response of Save button and bad order of Selected Groups
After:
