Reorganize the logic in lookup_attrs for AutomateSimulationTree #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
changed the title
skateman
force-pushed
the
fix-automate-simulation-tree
branch
from
066c97f to
6825f34
Compare
|
👍 |
skateman
force-pushed
the
fix-automate-simulation-tree
branch
from
6825f34 to
e46da6f
Compare
skateman
changed the title
|
@mkanoor thanks, rebased and ready to merge! |
|
Checked commits skateman/manageiq-ui-classic@f7d115a~...e46da6f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot assign @mzazrivec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
elseblock inlookup_attrswas handling some non-MiqAeService elements that are covered byMiqAeClassHelper#ae_field_fonticon, so I reorganized the code structure a bit. As we might not have the full list of all the possible non-MiqAeService elements, theae_field_fonticonthrows a descriptive error if an icon is missing.The first commit fixes #714, but throws an exception as there is no fonticon defined for
Element. The second commit adds a the missing icon that has been created by @epwinchell in #731.