-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ad-hoc page css for new Patternfly version #826
Fix ad-hoc page css for new Patternfly version #826
Conversation
@miq-bot add_label compute/containers @himdel @jeff-phillips-18 help , I do not understand why the filter's main select widget doesn't work here, any idea ? All dropdown works except the main filter dropdown, the little border under the button is connected with the items list (ul element with the items that should show when button is pressed): cc @simon3z p.s. |
@skateman ping, hi, can you help with the pfFilter thing ? |
note: the pfFilter is broken in the alerts page too cc @moolitayer |
80f04e1
to
8eb284a
Compare
8eb284a
to
9504492
Compare
9504492
to
64018fc
Compare
Checked commit yaacov@64018fc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@miq-bot add_label bug |
@himdel please review here is a provider for testing: |
Aah, looks much better, thanks! :) Merging.. |
@miq-bot add_label euwe/no, fine/yes |
@himdel we need this is fine, because the bad layout is in fine. |
…ad-hoc-page Fix ad-hoc page css for new Patternfly version (cherry picked from commit 99f6d78)
Fine backport details:
|
Description
#402 updated the Patternfly version in ManageIQ, this PR has some little css fixes for the ad-hoc page.
Screenshot
![screenshot-localhost 3000-2017-03-28-17-56-40](https://cloud.githubusercontent.com/assets/2181522/24412013/ff3aca56-13df-11e7-8fa7-a89ffca2f942.png)
Broken
Fixed css
![screenshot-localhost 3000-2017-03-29-16-55-42](https://cloud.githubusercontent.com/assets/2181522/24458154/c89d836e-14a0-11e7-9d4e-e6f08f7bc35b.png)