BZ#1490510 - Recalibrates snapshot timeline start/end for better visibility #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskacerguis
suggested changes
Sep 27, 2017
| eventHover: showTooltip, | ||
| eventGrouping: 60000, | ||
| minScale: (week / month), | ||
| maxScale: (day / 60000), |
There was a problem hiding this comment.
doesn't need trailing comma
Ensures dateFormat on d3.timeline is inrofmed by local option flag Removes min/max scale suggested defaults
AllenBW
force-pushed
the
BZ/1490510-snapshots
branch
from
93171e4 to
0071b9c
Compare
|
Checked commit AllenBW@0071b9c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
chriskacerguis
approved these changes
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1490510
Ensures dateFormat on d3.timeline is informed by local option flag
Removes min/max scale suggested defaults
No ux changes here, just addressing the bz
@sshveta