BZ 1490103 - Fixed issue for VM custom button actions #1022
Conversation
|
@chalettu can you please address that NSP fail? |
|
I checked the library that is the culprit. It is a mime package. This vulnerability was released today and our dependent packages that depend on that package have not been updated yet. I recommend we ignore it for now. |
|
Thanks for the info. @AllenBW I'm good with the merge (with this being so new). Your vote? |
| @@ -122,4 +122,80 @@ describe('services.custom_button_details', function() { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Custom button actions for a VM', () => { | |||
| var collectionsApiSpy; | |||
There was a problem hiding this comment.
prefer, const or let to var. consider stacking all the ones without assignments on the same line
| @@ -51,6 +73,7 @@ function StateController ($state, $stateParams, dialog, service, CollectionsApi, | |||
| vm.dialogs = dialog.content | |||
| vm.service = service | |||
| vm.serviceId = $stateParams.serviceId | |||
| vm.vmId = ($stateParams.vmId ? $stateParams.vmId : null) | |||
There was a problem hiding this comment.
$stateParams.vmId || null ternary might be a bit of overkill
| @@ -25,6 +25,28 @@ function getStates () { | |||
| dialog: resolveDialog, | |||
| service: resolveService | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
these two states appear very similar, instead of duplicating the code with a mild name change, why not make the vmId an optional param on the existing state?
There was a problem hiding this comment.
Thought about it. It is really just a judgement call. Initially I wanted to make it this way so we could refresh the page successfully but it looks like we are passing button data and that isn't reproducible so we can't refresh either way. I am kinda fine either way.
|
|
|
Checked commits https://github.com/chalettu/manageiq-ui-service/compare/1510ae133abf4a8ce869fff596b1c735ee15cec1~...0ffc636186ab37d43453e269797c6e46407c9272 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@miq-bot add_label bug
@miq-bot add_label fine/no
BZ https://bugzilla.redhat.com/show_bug.cgi?id=1490103