We were still disabling snapsot revert for all but the current snapshot #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533817 Now all snapshots can be reverted to and from
AllenBW
force-pushed
the
bug/master/#1534059-revert-snapshot-fail
branch
from
403f131 to
76cd712
Compare
|
Checked commit AllenBW@76cd712 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
himdel
approved these changes
Jan 19, 2018
There was a problem hiding this comment.
LGTM 👍
#1358 made it possible to revert to snapshots without parent
this PR makes it possible to revert to the current snapshot
Ops UI doesn't seem to limit this in any way (except for filtering out cloud Openstack VMs) so this (almost) matches.
simaishi
pushed a commit
that referenced
this pull request
Jan 19, 2018
…shot-fail We were still disabling snapsot revert for all but the current snapshot (cherry picked from commit 4f1c1e6) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1534059
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533817
Now all snapshots can be reverted to and from
because one pr ( #1358 ) isn't enough to solve the problem
puddin' PROOF