Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAPRINDASHVILI] Componetizes the dashboard to fix group switching and lnav #1378

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Feb 6, 2018

#1373 for Gaprindashvili

@miq-bot
Copy link
Member

miq-bot commented Feb 6, 2018

Checked commit AllenBW@a8f26e9 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works in gaprindsahvili :)

@simaishi simaishi changed the title [GAPRINDASHVILI]Componetizes the dashboard to fix group switching and lnav [GAPRINDASHVILI] Componetizes the dashboard to fix group switching and lnav Feb 6, 2018
@simaishi simaishi merged commit 7d74a9d into ManageIQ:gaprindashvili Feb 6, 2018
@simaishi simaishi added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 6, 2018
@AllenBW AllenBW deleted the enhancement/gaprinsashvili/#1533222-componentize-dashboard branch February 6, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants