Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved action button to the bottom of the form #1384

Merged
merged 2 commits into from
Mar 12, 2018

Conversation

@miq-bot miq-bot added the wip label Feb 13, 2018
@AllenBW AllenBW self-requested a review February 13, 2018 15:32
@AllenBW AllenBW self-assigned this Feb 13, 2018
@AllenBW
Copy link
Member

AllenBW commented Feb 27, 2018

@romanblanco is this still a wip?

@romanblanco
Copy link
Member Author

@AllenBW Forgot about this, but yes, I still need to add the 'Cancel' button (#1377 (comment))

@romanblanco romanblanco changed the title [WIP] Moved action button to the bottom of the form Moved action button to the bottom of the form Mar 9, 2018
@romanblanco
Copy link
Member Author

@AllenBW ready for review. I'm not sure if ui-sref is the right thing to use, but looks like it works OK

@miq-bot
Copy link
Member

miq-bot commented Mar 9, 2018

Checked commits romanblanco/manageiq-ui-service@44e9557~...27a6d0a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@miq-bot miq-bot removed the wip label Mar 9, 2018
@AllenBW
Copy link
Member

AllenBW commented Mar 12, 2018

@romanblanco any way we can get a gif of this in action? or some screen shots? Is there a bz that this work aligns with, or does it need one?

@romanblanco
Copy link
Member Author

@AllenBW gif (after changes):

screencast from 2018-03-12 16-45-20

No BZ :-)

@AllenBW AllenBW added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 12, 2018
@serenamarie125
Copy link

@romanblanco it would be great to have a fixed button bar on the bottom ( similar to how paging works. ), so that the buttons are always viewable

@AllenBW
Copy link
Member

AllenBW commented Mar 12, 2018

Something like what the wizard has?
screen shot 2018-03-12 at 1 27 21 pm

http://www.patternfly.org/pattern-library/communication/wizard/

Copy link

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@serenamarie125
Copy link

yes @AllenBW but after just chatting with you, I think that I'm 👍 this !

@serenamarie125
Copy link

@miq-bot add_label ux/approved
@miq-bot remove_label ux/review

Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns dialog form submit buttons with pf style, 😋 😍 🙇

Thanks @romanblanco !

@AllenBW AllenBW merged commit ed710be into ManageIQ:master Mar 12, 2018
@romanblanco romanblanco deleted the action_button branch March 12, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants