-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved action button to the bottom of the form #1384
Conversation
@romanblanco is this still a wip? |
@AllenBW Forgot about this, but yes, I still need to add the 'Cancel' button (#1377 (comment)) |
5ee53d1
to
27a6d0a
Compare
@AllenBW ready for review. I'm not sure if |
Checked commits romanblanco/manageiq-ui-service@44e9557~...27a6d0a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@romanblanco any way we can get a gif of this in action? or some screen shots? Is there a bz that this work aligns with, or does it need one? |
@AllenBW gif (after changes): No BZ :-) |
@romanblanco it would be great to have a fixed button bar on the bottom ( similar to how paging works. ), so that the buttons are always viewable |
Something like what the wizard has? http://www.patternfly.org/pattern-library/communication/wizard/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
yes @AllenBW but after just chatting with you, I think that I'm 👍 this ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aligns dialog form submit buttons with pf style, 😋 😍 🙇
Thanks @romanblanco !
Fixes: #1377
http://www.patternfly.org/pattern-library/forms-and-controls/buttons-on-forms/#overview
https://rawgit.com/patternfly/patternfly/master-dist/dist/tests/forms.html